You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2015/10/12 19:44:33 UTC
Re: Review Request 39019: [WORK IN PROGRESS,
NOT IMMEDIATELY NECESSARY] Windows: Added dirent compat code for non-Unix
systems.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39019/
-----------------------------------------------------------
(Updated Oct. 12, 2015, 5:44 p.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Summary (updated)
-----------------
[WORK IN PROGRESS, NOT IMMEDIATELY NECESSARY] Windows: Added dirent compat code for non-Unix systems.
Repository: mesos
Description
-------
Windows: Added dirent compat code for non-Unix systems.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp PRE-CREATION
3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 50e35f43d87c69a83a9e7d039d1881404ea8be38
Diff: https://reviews.apache.org/r/39019/diff/
Testing
-------
Thanks,
Alex Clemmer
Re: Review Request 39019: Windows: Added dirent compat code for
non-Unix systems.
Posted by Alex Clemmer <cl...@gmail.com>.
> On Dec. 12, 2015, 8:09 p.m., Joris Van Remoortere wrote:
> > Let's get some Windows team reviews on this.
> > let's try and use snake_case in stout.
Wasn't sure where you wanted me to use snake_case, so those changes aren't reflected in iteration 8.
- Alex
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39019/#review110101
-----------------------------------------------------------
On Dec. 23, 2015, 2:12 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39019/
> -----------------------------------------------------------
>
> (Updated Dec. 23, 2015, 2:12 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3441
> https://issues.apache.org/jira/browse/MESOS-3441
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Added dirent compat code for non-Unix systems.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp PRE-CREATION
> 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp d46e262e0fd1c2de36f3bf19d8bd693c23bf58cd
>
> Diff: https://reviews.apache.org/r/39019/diff/
>
>
> Testing
> -------
>
> `make check` from autotools on Ubuntu 15.
> `make check` from CMake on OS X 10.10.
> Ran `check` project in VS on Windows 10.
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 39019: Windows: Added dirent compat code for
non-Unix systems.
Posted by Alex Clemmer <cl...@gmail.com>.
> On Dec. 12, 2015, 8:09 p.m., Joris Van Remoortere wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp, lines 198-200
> > <https://reviews.apache.org/r/39019/diff/8/?file=1128789#file1128789line198>
> >
> > Where does the internal data for DIR get freed?
Oh god. How embarrassing. In my defense, I have no idea what I'm doing. I have written maybe 30 lines of "real C", ever. I feel bad about this. :(
- Alex
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39019/#review110101
-----------------------------------------------------------
On Dec. 23, 2015, 2:12 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39019/
> -----------------------------------------------------------
>
> (Updated Dec. 23, 2015, 2:12 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3441
> https://issues.apache.org/jira/browse/MESOS-3441
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Added dirent compat code for non-Unix systems.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp PRE-CREATION
> 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp d46e262e0fd1c2de36f3bf19d8bd693c23bf58cd
>
> Diff: https://reviews.apache.org/r/39019/diff/
>
>
> Testing
> -------
>
> `make check` from autotools on Ubuntu 15.
> `make check` from CMake on OS X 10.10.
> Ran `check` project in VS on Windows 10.
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 39019: Windows: Added dirent compat code for
non-Unix systems.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39019/#review110101
-----------------------------------------------------------
Let's get some Windows team reviews on this.
let's try and use snake_case in stout.
3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp (lines 17 - 18)
<https://reviews.apache.org/r/39019/#comment169882>
alphabetize.
3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp (line 26)
<https://reviews.apache.org/r/39019/#comment169883>
brace on new line.
3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp (lines 53 - 55)
<https://reviews.apache.org/r/39019/#comment169884>
As Joseph mentioned, this `NOTE:` is not necessary.
3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp (line 81)
<https://reviews.apache.org/r/39019/#comment169885>
`directory == NULL`
3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp (line 89)
<https://reviews.apache.org/r/39019/#comment169886>
`directory->d_name == NULL`
3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp (lines 198 - 200)
<https://reviews.apache.org/r/39019/#comment169888>
Where does the internal data for DIR get freed?
- Joris Van Remoortere
On Nov. 17, 2015, 7:06 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39019/
> -----------------------------------------------------------
>
> (Updated Nov. 17, 2015, 7:06 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3441
> https://issues.apache.org/jira/browse/MESOS-3441
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Added dirent compat code for non-Unix systems.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp PRE-CREATION
> 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 1a7037d64afeedc340258c92067e95d1d3caa027
>
> Diff: https://reviews.apache.org/r/39019/diff/
>
>
> Testing
> -------
>
> `make check` from autotools on Ubuntu 15.
> `make check` from CMake on OS X 10.10.
> Ran `check` project in VS on Windows 10.
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 39019: Windows: Added dirent compat code for
non-Unix systems.
Posted by Alex Clemmer <cl...@gmail.com>.
> On Dec. 15, 2015, 4:24 a.m., Alex Naparu wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp, line 79
> > <https://reviews.apache.org/r/39019/diff/8/?file=1128789#file1128789line79>
> >
> > Consider using a smart pointer instead. Same below.
I would love to use a smart pointer, but unfortunately, the goal here is to make a drop-in replacement for the POSIX `dirent` API, which is in raw C.
> On Dec. 15, 2015, 4:24 a.m., Alex Naparu wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp, line 215
> > <https://reviews.apache.org/r/39019/diff/8/?file=1128789#file1128789line215>
> >
> > This is copied here, but malloc'd elsewhere. Is that safe?
I'm no C expert by any stretch of the imagination, but I believe this is safe. The reason is, we're actually not `malloc`'ing that array at all, we're `strcpy`'ing a path into a stack-allocated array of `MAX_PATH` in length. According to [1], this includes null terminator, so I think this is ok to do.
[1] https://msdn.microsoft.com/en-us/library/windows/desktop/aa365247(v=vs.85).aspx
> On Dec. 15, 2015, 4:24 a.m., Alex Naparu wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp, line 230
> > <https://reviews.apache.org/r/39019/diff/8/?file=1128789#file1128789line230>
> >
> > Consider using safe versions of string functions
I'm not an expert in C or Windows, but looking at this, it seems like we can't use `strncpy` or `strcpy_s` for the potentially-insecure call to `strcpy` in `opendir` (since we don't know the length of `path` ahead of time), and for the calls to `strcpy` that we can use these functions, it's not helpful, because they are `strcpy`'ing stuff from Windows API calls like `FindNextFile`, which should be outputting something sensible anyway.
So, it seems like this is probably not worth changing? What do you think?
> On Dec. 15, 2015, 4:24 a.m., Alex Naparu wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp, line 74
> > <https://reviews.apache.org/r/39019/diff/8/?file=1128790#file1128790line74>
> >
> > Might want to add this as a reference too: https://msdn.microsoft.com/en-us/library/930f87yf.aspx
> >
> > MAX_PATH is horribly obsolete, we might want to consider checking whether we're running on NTFS for all FS-related ops. That will be true in the vast majority of cases these days.
I actually expect that we will probably mostly never run on FAT at all, but I wasn't super well versed in how to get the Windows API to not use the FAT limitations, so we went with mostly FAT-limited APIs, because they seemed simpler. That said, I'm not an expert at either Windows or C++, so maybe this was all just naive.
- Alex
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39019/#review110392
-----------------------------------------------------------
On Nov. 17, 2015, 7:06 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39019/
> -----------------------------------------------------------
>
> (Updated Nov. 17, 2015, 7:06 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3441
> https://issues.apache.org/jira/browse/MESOS-3441
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Added dirent compat code for non-Unix systems.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp PRE-CREATION
> 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 1a7037d64afeedc340258c92067e95d1d3caa027
>
> Diff: https://reviews.apache.org/r/39019/diff/
>
>
> Testing
> -------
>
> `make check` from autotools on Ubuntu 15.
> `make check` from CMake on OS X 10.10.
> Ran `check` project in VS on Windows 10.
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 39019: Windows: Added dirent compat code for
non-Unix systems.
Posted by Alex Naparu <al...@outlook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39019/#review110392
-----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp (line 79)
<https://reviews.apache.org/r/39019/#comment170225>
Consider using a smart pointer instead. Same below.
3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp (line 215)
<https://reviews.apache.org/r/39019/#comment170231>
This is copied here, but malloc'd elsewhere. Is that safe?
3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp (line 230)
<https://reviews.apache.org/r/39019/#comment170237>
Consider using safe versions of string functions
3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp (line 74)
<https://reviews.apache.org/r/39019/#comment170220>
Might want to add this as a reference too: https://msdn.microsoft.com/en-us/library/930f87yf.aspx
MAX_PATH is horribly obsolete, we might want to consider checking whether we're running on NTFS for all FS-related ops. That will be true in the vast majority of cases these days.
- Alex Naparu
On Nov. 17, 2015, 7:06 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39019/
> -----------------------------------------------------------
>
> (Updated Nov. 17, 2015, 7:06 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3441
> https://issues.apache.org/jira/browse/MESOS-3441
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Added dirent compat code for non-Unix systems.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp PRE-CREATION
> 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 1a7037d64afeedc340258c92067e95d1d3caa027
>
> Diff: https://reviews.apache.org/r/39019/diff/
>
>
> Testing
> -------
>
> `make check` from autotools on Ubuntu 15.
> `make check` from CMake on OS X 10.10.
> Ran `check` project in VS on Windows 10.
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 39019: Windows: Added dirent compat code for
non-Unix systems.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39019/
-----------------------------------------------------------
(Updated Dec. 23, 2015, 2:12 a.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Bugs: MESOS-3441
https://issues.apache.org/jira/browse/MESOS-3441
Repository: mesos
Description
-------
Windows: Added dirent compat code for non-Unix systems.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp PRE-CREATION
3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp d46e262e0fd1c2de36f3bf19d8bd693c23bf58cd
Diff: https://reviews.apache.org/r/39019/diff/
Testing
-------
`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
Re: Review Request 39019: Windows: Added dirent compat code for
non-Unix systems.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39019/
-----------------------------------------------------------
(Updated Nov. 17, 2015, 7:06 p.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Bugs: MESOS-3441
https://issues.apache.org/jira/browse/MESOS-3441
Repository: mesos
Description
-------
Windows: Added dirent compat code for non-Unix systems.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp PRE-CREATION
3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 1a7037d64afeedc340258c92067e95d1d3caa027
Diff: https://reviews.apache.org/r/39019/diff/
Testing
-------
`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
Re: Review Request 39019: Windows: Added dirent compat code for
non-Unix systems.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39019/
-----------------------------------------------------------
(Updated Nov. 17, 2015, 7:02 p.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Bugs: MESOS-3441
https://issues.apache.org/jira/browse/MESOS-3441
Repository: mesos
Description
-------
Windows: Added dirent compat code for non-Unix systems.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp PRE-CREATION
3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 1a7037d64afeedc340258c92067e95d1d3caa027
Diff: https://reviews.apache.org/r/39019/diff/
Testing
-------
`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
Re: Review Request 39019: Windows: Added dirent compat code for
non-Unix systems.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39019/
-----------------------------------------------------------
(Updated Nov. 16, 2015, 9:13 a.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Bugs: MESOS-3441
https://issues.apache.org/jira/browse/MESOS-3441
Repository: mesos
Description
-------
Windows: Added dirent compat code for non-Unix systems.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp PRE-CREATION
3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 1a7037d64afeedc340258c92067e95d1d3caa027
Diff: https://reviews.apache.org/r/39019/diff/
Testing
-------
`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
Re: Review Request 39019: Windows: Added dirent compat code for
non-Unix systems.
Posted by Alex Clemmer <cl...@gmail.com>.
> On Nov. 2, 2015, 8:43 p.m., Joseph Wu wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp, line 43
> > <https://reviews.apache.org/r/39019/diff/5/?file=1112922#file1112922line43>
> >
> > Presumably, this will always be true for Stout. So do we need the `#ifdef`?
Yes, that's fair. This issue should be resolved.
- Alex
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39019/#review104784
-----------------------------------------------------------
On Nov. 16, 2015, 9:13 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39019/
> -----------------------------------------------------------
>
> (Updated Nov. 16, 2015, 9:13 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3441
> https://issues.apache.org/jira/browse/MESOS-3441
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Added dirent compat code for non-Unix systems.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp PRE-CREATION
> 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 1a7037d64afeedc340258c92067e95d1d3caa027
>
> Diff: https://reviews.apache.org/r/39019/diff/
>
>
> Testing
> -------
>
> `make check` from autotools on Ubuntu 15.
> `make check` from CMake on OS X 10.10.
> Ran `check` project in VS on Windows 10.
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 39019: Windows: Added dirent compat code for
non-Unix systems.
Posted by Alex Clemmer <cl...@gmail.com>.
> On Nov. 2, 2015, 8:43 p.m., Joseph Wu wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp, line 43
> > <https://reviews.apache.org/r/39019/diff/5/?file=1112922#file1112922line43>
> >
> > Presumably, this will always be true for Stout. So do we need the `#ifdef`?
>
> Alex Clemmer wrote:
> Yes, that's fair. This issue should be resolved.
Note that the spaces are now pulled out from around the `extern` tags because the linter asks for it.
- Alex
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39019/#review104784
-----------------------------------------------------------
On Nov. 17, 2015, 7:06 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39019/
> -----------------------------------------------------------
>
> (Updated Nov. 17, 2015, 7:06 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3441
> https://issues.apache.org/jira/browse/MESOS-3441
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Added dirent compat code for non-Unix systems.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp PRE-CREATION
> 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 1a7037d64afeedc340258c92067e95d1d3caa027
>
> Diff: https://reviews.apache.org/r/39019/diff/
>
>
> Testing
> -------
>
> `make check` from autotools on Ubuntu 15.
> `make check` from CMake on OS X 10.10.
> Ran `check` project in VS on Windows 10.
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 39019: Windows: Added dirent compat code for
non-Unix systems.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39019/#review104784
-----------------------------------------------------------
Where's the `Makefile` change?
3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp (line 43)
<https://reviews.apache.org/r/39019/#comment163028>
Presumably, this will always be true for Stout. So do we need the `#ifdef`?
3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp (lines 50 - 52)
<https://reviews.apache.org/r/39019/#comment163025>
Maybe add a `// Forward declarations.` comment here.
- Joseph Wu
On Oct. 29, 2015, 10:59 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39019/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2015, 10:59 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3441
> https://issues.apache.org/jira/browse/MESOS-3441
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Added dirent compat code for non-Unix systems.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp PRE-CREATION
> 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 1a7037d64afeedc340258c92067e95d1d3caa027
>
> Diff: https://reviews.apache.org/r/39019/diff/
>
>
> Testing
> -------
>
> `make check` from autotools on Ubuntu 15.
> `make check` from CMake on OS X 10.10.
> Ran `check` project in VS on Windows 10.
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 39019: Windows: Added dirent compat code for
non-Unix systems.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39019/
-----------------------------------------------------------
(Updated Oct. 30, 2015, 5:59 a.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Bugs: MESOS-3441
https://issues.apache.org/jira/browse/MESOS-3441
Repository: mesos
Description
-------
Windows: Added dirent compat code for non-Unix systems.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp PRE-CREATION
3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 1a7037d64afeedc340258c92067e95d1d3caa027
Diff: https://reviews.apache.org/r/39019/diff/
Testing
-------
`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
Re: Review Request 39019: Windows: Added dirent compat code for
non-Unix systems.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39019/#review103904
-----------------------------------------------------------
Patch looks great!
Reviews applied: [39537, 39538, 39539, 39540, 39541, 39383, 39559, 39219, 39560, 39583, 39584, 39620, 39621, 39622, 39623, 39019]
All tests passed.
- Mesos ReviewBot
On Oct. 24, 2015, 6:42 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39019/
> -----------------------------------------------------------
>
> (Updated Oct. 24, 2015, 6:42 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3441
> https://issues.apache.org/jira/browse/MESOS-3441
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Added dirent compat code for non-Unix systems.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp PRE-CREATION
> 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 7a8819541506f57f70a9b577dc97a76fc26ebaa8
>
> Diff: https://reviews.apache.org/r/39019/diff/
>
>
> Testing
> -------
>
> `make check` from autotools on Ubuntu 15.
> `make check` from CMake on OS X 10.10.
> Ran `check` project in VS on Windows 10.
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 39019: Windows: Added dirent compat code for
non-Unix systems.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39019/
-----------------------------------------------------------
(Updated Oct. 24, 2015, 6:42 p.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Bugs: MESOS-3441
https://issues.apache.org/jira/browse/MESOS-3441
Repository: mesos
Description
-------
Windows: Added dirent compat code for non-Unix systems.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp PRE-CREATION
3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 7a8819541506f57f70a9b577dc97a76fc26ebaa8
Diff: https://reviews.apache.org/r/39019/diff/
Testing
-------
`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
Re: Review Request 39019: Windows: Added dirent compat code for
non-Unix systems.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39019/
-----------------------------------------------------------
(Updated Oct. 24, 2015, 6:39 p.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Summary (updated)
-----------------
Windows: Added dirent compat code for non-Unix systems.
Bugs: MESOS-3441
https://issues.apache.org/jira/browse/MESOS-3441
Repository: mesos
Description
-------
Windows: Added dirent compat code for non-Unix systems.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp PRE-CREATION
3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 7a8819541506f57f70a9b577dc97a76fc26ebaa8
Diff: https://reviews.apache.org/r/39019/diff/
Testing
-------
`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
Re: Review Request 39019: [WORK IN PROGRESS,
NOT IMMEDIATELY NECESSARY] Windows: Added dirent compat code for non-Unix
systems.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39019/
-----------------------------------------------------------
(Updated Oct. 22, 2015, 3:35 a.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Bugs: MESOS-3441
https://issues.apache.org/jira/browse/MESOS-3441
Repository: mesos
Description
-------
Windows: Added dirent compat code for non-Unix systems.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp PRE-CREATION
3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 50e35f43d87c69a83a9e7d039d1881404ea8be38
Diff: https://reviews.apache.org/r/39019/diff/
Testing (updated)
-------
`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer