[GitHub] [datasketches-cpp] AlexanderSaydakov commented on a diff in pull request #391: removed static tests replaced by dynamic ones

["AlexanderSaydakov (via GitHub)" <gi...@apache.org>]

AlexanderSaydakov commented on code in PR #391:
URL: https://github.com/apache/datasketches-cpp/pull/391#discussion_r1299061990


##########
kll/test/kll_sketch_deserialize_from_java_test.cpp:
##########
@@ -75,4 +75,29 @@ TEST_CASE("kll double", "[serde_compat]") {
   }
 }
 
+// numbers are padded with leading spaces so that natural order works

Review Comment:
   this is how it was done on the Java side during sketch updates presumably to avoid supplying a custom comparator



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org