You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/11/01 23:09:14 UTC
[kudu-CR] [docs] add info on KUDU-2990 into known issues
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14616
Change subject: [docs] add info on KUDU-2990 into known issues
......................................................................
[docs] add info on KUDU-2990 into known issues
Change-Id: I786c561c6b84c5181b799dca881eab9833383c8d
---
M docs/known_issues.adoc
1 file changed, 9 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/16/14616/1
--
To view, visit http://gerrit.cloudera.org:8080/14616
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I786c561c6b84c5181b799dca881eab9833383c8d
Gerrit-Change-Number: 14616
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [docs] add info on KUDU-2990 into known issues
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14616 )
Change subject: [docs] add info on KUDU-2990 into known issues
......................................................................
Patch Set 3: Verified+1
Unrelated test failure: this is a doc-only patch.
--
To view, visit http://gerrit.cloudera.org:8080/14616
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I786c561c6b84c5181b799dca881eab9833383c8d
Gerrit-Change-Number: 14616
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 02 Nov 2019 20:43:25 +0000
Gerrit-HasComments: No
[kudu-CR] [docs] add info on KUDU-2990 into known issues
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Grant Henke, Greg Solovyev,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14616
to look at the new patch set (#3).
Change subject: [docs] add info on KUDU-2990 into known issues
......................................................................
[docs] add info on KUDU-2990 into known issues
Change-Id: I786c561c6b84c5181b799dca881eab9833383c8d
---
M docs/known_issues.adoc
1 file changed, 11 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/16/14616/3
--
To view, visit http://gerrit.cloudera.org:8080/14616
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I786c561c6b84c5181b799dca881eab9833383c8d
Gerrit-Change-Number: 14616
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [docs] add info on KUDU-2990 into known issues
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14616 )
Change subject: [docs] add info on KUDU-2990 into known issues
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/14616/1/docs/known_issues.adoc
File docs/known_issues.adoc:
http://gerrit.cloudera.org:8080/#/c/14616/1/docs/known_issues.adoc@208
PS1, Line 208: contenerized
> containerized
Done
http://gerrit.cloudera.org:8080/#/c/14616/1/docs/known_issues.adoc@214
PS1, Line 214: upcoming patch release
> upcoming patch releases (since multiple releases may be involved).
Done
--
To view, visit http://gerrit.cloudera.org:8080/14616
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I786c561c6b84c5181b799dca881eab9833383c8d
Gerrit-Change-Number: 14616
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 02 Nov 2019 01:09:43 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] add info on KUDU-2990 into known issues
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14616 )
Change subject: [docs] add info on KUDU-2990 into known issues
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/14616/1/docs/known_issues.adoc
File docs/known_issues.adoc:
PS1:
FWIW, the source distribution is also in violation of the policy. Not sure if you want to work that into the RN, or whether you think the binary distribution is more important to doc.
http://gerrit.cloudera.org:8080/#/c/14616/1/docs/known_issues.adoc@208
PS1, Line 208: contenerized
containerized
http://gerrit.cloudera.org:8080/#/c/14616/1/docs/known_issues.adoc@214
PS1, Line 214: upcoming patch release
upcoming patch releases (since multiple releases may be involved).
--
To view, visit http://gerrit.cloudera.org:8080/14616
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I786c561c6b84c5181b799dca881eab9833383c8d
Gerrit-Change-Number: 14616
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 01 Nov 2019 23:22:10 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] add info on KUDU-2990 into known issues
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [docs] add info on KUDU-2990 into known issues
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/14616
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I786c561c6b84c5181b799dca881eab9833383c8d
Gerrit-Change-Number: 14616
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [docs] add info on KUDU-2990 into known issues
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14616 )
Change subject: [docs] add info on KUDU-2990 into known issues
......................................................................
Patch Set 2: Verified+1
Unrelated test failures: this is a doc-only patch.
--
To view, visit http://gerrit.cloudera.org:8080/14616
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I786c561c6b84c5181b799dca881eab9833383c8d
Gerrit-Change-Number: 14616
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 02 Nov 2019 02:25:19 +0000
Gerrit-HasComments: No
***UNCHECKED***[kudu-CR] [docs] add info on KUDU-2990 into known issues
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14616 )
Change subject: [docs] add info on KUDU-2990 into known issues
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14616/1/docs/known_issues.adoc
File docs/known_issues.adoc:
PS1:
> FWIW, the source distribution is also in violation of the policy. Not sure
It's a good question. I'm not sure about the violation in the source distribution. The source distro doesn't include libnuma project, right?
In other words, I'm not sure that having a link to the source tarball means'including' the project.
Does ASF site has definition of what 'include' means? I'm not sure I find a good one.
--
To view, visit http://gerrit.cloudera.org:8080/14616
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I786c561c6b84c5181b799dca881eab9833383c8d
Gerrit-Change-Number: 14616
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 02 Nov 2019 00:14:11 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] add info on KUDU-2990 into known issues
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14616 )
Change subject: [docs] add info on KUDU-2990 into known issues
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14616
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I786c561c6b84c5181b799dca881eab9833383c8d
Gerrit-Change-Number: 14616
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sun, 03 Nov 2019 21:28:07 +0000
Gerrit-HasComments: No
[kudu-CR] [docs] add info on KUDU-2990 into known issues
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14616 )
Change subject: [docs] add info on KUDU-2990 into known issues
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14616/1/docs/known_issues.adoc
File docs/known_issues.adoc:
PS1:
> BTW, if the fact of adding a link to the source tarball to be used during b
The 3rd party license policy page has an eerily similar example for "what's OK":
Apache projects may not distribute Category X licensed components, be it in source or binary form; and be it in ASF source code or convenience binaries. As with the previous question on platforms, the component can be relied on if the component's license terms do not affect the Apache product's licensing. For example, using a GPL'ed tool during the build is OK, however including GPL'ed source code is not.
Bison is only used at build time, so I don't think it's an issue.
Back to the source distribution: you're right that, technically speaking, libnuma source is not distributed by Kudu. However, it's impossible to build the product from the source distribution and avoid linking against libnuma without first heavily editing the source. And given that the best practice for building is to use a RELEASE build, you'd also wind up distributing libnuma along with the Kudu binaries (by virtue of static linkage). That's why I ultimately interpreted libnuma as being "part of the source distribution".
--
To view, visit http://gerrit.cloudera.org:8080/14616
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I786c561c6b84c5181b799dca881eab9833383c8d
Gerrit-Change-Number: 14616
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 02 Nov 2019 05:07:57 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] add info on KUDU-2990 into known issues
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14616 )
Change subject: [docs] add info on KUDU-2990 into known issues
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14616/1/docs/known_issues.adoc
File docs/known_issues.adoc:
PS1:
> It's a good question. I'm not sure about the violation in the source distr
BTW, if the fact of adding a link to the source tarball to be used during build/testing is 'inclusion' of such a sort, then we should take care of bison that has been in Kudu 1.6.0 (see changelist 31d16f7493544c850e019f1d2fdc7eef6e2c2258). The bad news is that it's under GPLv3.
--
To view, visit http://gerrit.cloudera.org:8080/14616
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I786c561c6b84c5181b799dca881eab9833383c8d
Gerrit-Change-Number: 14616
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 02 Nov 2019 01:05:35 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] add info on KUDU-2990 into known issues
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Grant Henke, Greg Solovyev,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14616
to look at the new patch set (#2).
Change subject: [docs] add info on KUDU-2990 into known issues
......................................................................
[docs] add info on KUDU-2990 into known issues
Change-Id: I786c561c6b84c5181b799dca881eab9833383c8d
---
M docs/known_issues.adoc
1 file changed, 9 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/16/14616/2
--
To view, visit http://gerrit.cloudera.org:8080/14616
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I786c561c6b84c5181b799dca881eab9833383c8d
Gerrit-Change-Number: 14616
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [docs] add info on KUDU-2990 into known issues
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [docs] add info on KUDU-2990 into known issues
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/14616
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I786c561c6b84c5181b799dca881eab9833383c8d
Gerrit-Change-Number: 14616
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [docs] add info on KUDU-2990 into known issues
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14616 )
Change subject: [docs] add info on KUDU-2990 into known issues
......................................................................
[docs] add info on KUDU-2990 into known issues
Change-Id: I786c561c6b84c5181b799dca881eab9833383c8d
Reviewed-on: http://gerrit.cloudera.org:8080/14616
Tested-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M docs/known_issues.adoc
1 file changed, 11 insertions(+), 0 deletions(-)
Approvals:
Alexey Serbin: Verified
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/14616
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I786c561c6b84c5181b799dca881eab9833383c8d
Gerrit-Change-Number: 14616
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [docs] add info on KUDU-2990 into known issues
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14616 )
Change subject: [docs] add info on KUDU-2990 into known issues
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14616/1/docs/known_issues.adoc
File docs/known_issues.adoc:
PS1:
> The 3rd party license policy page has an eerily similar example for "what's
Thank you for the clarification. For some reason, I assumed the standard way of building the release Kudu binaries links the libnuma dynamically (as it's done for the binaries in the kudu-binary JAR for mini-cluster), but apparently that's not the case.
I added a note explaining the issue with the static linkage of the libnuma library.
--
To view, visit http://gerrit.cloudera.org:8080/14616
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I786c561c6b84c5181b799dca881eab9833383c8d
Gerrit-Change-Number: 14616
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 02 Nov 2019 19:36:51 +0000
Gerrit-HasComments: Yes