You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org> on 2021/08/11 18:08:49 UTC
[Impala-ASF-CR] IMPALA-8795: (Addendum) Fix test hms integration flakiness
Vihang Karajgaonkar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17767
Change subject: IMPALA-8795: (Addendum) Fix test_hms_integration flakiness
......................................................................
IMPALA-8795: (Addendum) Fix test_hms_integration flakiness
The previous commit for IMPALA-8795 modifies the
test_sanity test to account for event processing is enabled.
However, it missed removing a assert statement before
event processing check. This commit modifies the test
to remove the unnecessary assert which fails intermittently.
Testing:
Looped the test 25 times and make sure it works with
default configs.
Change-Id: I647e6a37dbfecd6a4500c8178ecc07e605cbcfba
---
M tests/metadata/test_hms_integration.py
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/67/17767/2
--
To view, visit http://gerrit.cloudera.org:8080/17767
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I647e6a37dbfecd6a4500c8178ecc07e605cbcfba
Gerrit-Change-Number: 17767
Gerrit-PatchSet: 2
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
[Impala-ASF-CR] IMPALA-8795: (Addendum) Fix test hms integration flakiness
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17767 )
Change subject: IMPALA-8795: (Addendum) Fix test_hms_integration flakiness
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/9283/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17767
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I647e6a37dbfecd6a4500c8178ecc07e605cbcfba
Gerrit-Change-Number: 17767
Gerrit-PatchSet: 2
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <ki...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 11 Aug 2021 18:33:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8795: (Addendum) Fix test hms integration flakiness
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17767 )
Change subject: IMPALA-8795: (Addendum) Fix test_hms_integration flakiness
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7387/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/17767
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I647e6a37dbfecd6a4500c8178ecc07e605cbcfba
Gerrit-Change-Number: 17767
Gerrit-PatchSet: 3
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 11 Aug 2021 18:13:23 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8795: (Addendum) Fix test hms integration flakiness
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
kishen@cloudera.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/17767 )
Change subject: IMPALA-8795: (Addendum) Fix test_hms_integration flakiness
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/17767
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I647e6a37dbfecd6a4500c8178ecc07e605cbcfba
Gerrit-Change-Number: 17767
Gerrit-PatchSet: 3
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <ki...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 11 Aug 2021 18:18:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8795: (Addendum) Fix test hms integration flakiness
Posted by "Andrew Sherman (Code Review)" <ge...@cloudera.org>.
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17767 )
Change subject: IMPALA-8795: (Addendum) Fix test_hms_integration flakiness
......................................................................
Patch Set 3: Code-Review+2
LGTM
--
To view, visit http://gerrit.cloudera.org:8080/17767
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I647e6a37dbfecd6a4500c8178ecc07e605cbcfba
Gerrit-Change-Number: 17767
Gerrit-PatchSet: 3
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <ki...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 11 Aug 2021 18:27:20 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8795: (Addendum) Fix test hms integration flakiness
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17767 )
Change subject: IMPALA-8795: (Addendum) Fix test_hms_integration flakiness
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/17767
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I647e6a37dbfecd6a4500c8178ecc07e605cbcfba
Gerrit-Change-Number: 17767
Gerrit-PatchSet: 3
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <ki...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 12 Aug 2021 00:23:46 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8795: (Addendum) Fix test hms integration flakiness
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17767 )
Change subject: IMPALA-8795: (Addendum) Fix test_hms_integration flakiness
......................................................................
IMPALA-8795: (Addendum) Fix test_hms_integration flakiness
The previous commit for IMPALA-8795 modifies the
test_sanity test to account for event processing is enabled.
However, it missed removing a assert statement before
event processing check. This commit modifies the test
to remove the unnecessary assert which fails intermittently.
Testing:
Looped the test 25 times and make sure it works with
default configs.
Change-Id: I647e6a37dbfecd6a4500c8178ecc07e605cbcfba
Reviewed-on: http://gerrit.cloudera.org:8080/17767
Reviewed-by: <ki...@cloudera.com>
Reviewed-by: Andrew Sherman <as...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/metadata/test_hms_integration.py
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
kishen@cloudera.com: Looks good to me, but someone else must approve
Andrew Sherman: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/17767
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I647e6a37dbfecd6a4500c8178ecc07e605cbcfba
Gerrit-Change-Number: 17767
Gerrit-PatchSet: 4
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <ki...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>