You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/07/02 15:23:14 UTC
[GitHub] [tvm] tqchen opened a new issue #8392: [BUG][FRONTEND] Pytorch Importer mm
tqchen opened a new issue #8392:
URL: https://github.com/apache/tvm/issues/8392
Caught this when reading through the code. Dense requires transposition.
https://github.com/apache/tvm/blob/main/python/tvm/relay/frontend/pytorch.py#L1880
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi commented on issue #8392: [BUG][FRONTEND] Pytorch Importer mm
Posted by GitBox <gi...@apache.org>.
masahi commented on issue #8392:
URL: https://github.com/apache/tvm/issues/8392#issuecomment-873415749
Sorry for the confusion, this converter is not used anywhere. Removed in https://github.com/apache/tvm/pull/8397
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi closed issue #8392: [BUG][FRONTEND] Pytorch Importer mm
Posted by GitBox <gi...@apache.org>.
masahi closed issue #8392:
URL: https://github.com/apache/tvm/issues/8392
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jcf94 edited a comment on issue #8392: [BUG][FRONTEND] Pytorch Importer mm
Posted by GitBox <gi...@apache.org>.
jcf94 edited a comment on issue #8392:
URL: https://github.com/apache/tvm/issues/8392#issuecomment-873726740
Sorry for my late reply, what's the latest update to this bug?
The `nn.matmul` should currently only be enabled in TensorFlow frontend with extra parameters.
Ok, seems it has been fixed in #8397 ? Thanks @masahi .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen commented on issue #8392: [BUG][FRONTEND] Pytorch Importer mm
Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #8392:
URL: https://github.com/apache/tvm/issues/8392#issuecomment-873407877
tracking an related error here https://discuss.tvm.apache.org/t/pytorch-unable-to-import-a-simple-torch-nn-linear-to-relay/10383
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen commented on issue #8392: [BUG][FRONTEND] Pytorch Importer mm
Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #8392:
URL: https://github.com/apache/tvm/issues/8392#issuecomment-873407918
cc @jcf94 @comaniac
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen commented on issue #8392: [BUG][FRONTEND] Pytorch Importer mm
Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #8392:
URL: https://github.com/apache/tvm/issues/8392#issuecomment-873078951
cc @masahi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jcf94 edited a comment on issue #8392: [BUG][FRONTEND] Pytorch Importer mm
Posted by GitBox <gi...@apache.org>.
jcf94 edited a comment on issue #8392:
URL: https://github.com/apache/tvm/issues/8392#issuecomment-873726740
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jcf94 commented on issue #8392: [BUG][FRONTEND] Pytorch Importer mm
Posted by GitBox <gi...@apache.org>.
jcf94 commented on issue #8392:
URL: https://github.com/apache/tvm/issues/8392#issuecomment-873726740
Sorry for my later replay, what's the latest update to this problem?
The `nn.matmul` should currently only be enabled in TensorFlow frontend with extra parameters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi commented on issue #8392: [BUG][FRONTEND] Pytorch Importer mm
Posted by GitBox <gi...@apache.org>.
masahi commented on issue #8392:
URL: https://github.com/apache/tvm/issues/8392#issuecomment-873410723
Yeah `torch.mm` expects non-transposed input, so our converter doesn't seem correct. https://pytorch.org/docs/stable/generated/torch.mm.html
I wonder why the test cases didn't catch this...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org