You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/25 13:40:12 UTC

[GitHub] [airflow] mik-laj commented on pull request #13308: Adds missing python-ldap dependency to LDAP extra.

mik-laj commented on pull request #13308:
URL: https://github.com/apache/airflow/pull/13308#issuecomment-751251261


   Should we add tests to detect if the library has installed correctly? As far as I can see, it has system dependencies, so there is a chance that updating the base image could cause problems that we could easily overlook. 
   
   I am thinking of a code similar to the following.
   ```python
   subprocess.run(['docker', '--rm',  $DOCKER_IMAGE, 'python', '-c', 'import ldap'])
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org