[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull request #1638: [SCB-1803] kie support long polling

[GitBox <gi...@apache.org>]

liubao68 commented on a change in pull request #1638: [SCB-1803] kie support long polling
URL: https://github.com/apache/servicecomb-java-chassis/pull/1638#discussion_r393554469
 
 

 ##########
 File path: dynamic-config/config-kie/src/main/java/org/apache/servicecomb/config/kie/client/KieClient.java
 ##########
 @@ -48,16 +49,27 @@
 
   private static final Logger LOGGER = LoggerFactory.getLogger(KieClient.class);
 
-  private ScheduledExecutorService EXECUTOR = Executors.newScheduledThreadPool(1);
+  private ScheduledExecutorService EXECUTOR = Executors.newScheduledThreadPool(1, (r) -> {
+    Thread thread = new Thread(r);
+    thread.setName("org.apache.servicecomb.config.kie");
+    thread.setDaemon(true);
+    return thread;
+  });
 
   private static final long TIME_OUT = 10000;
 
+  private static AtomicBoolean IS_FIRST_PULL = new AtomicBoolean(true);
+
+  private static final int LONG_POLLING_WAIT_TIME = 30;
 
 Review comment:
   long polling timeout is equals to client request timeout, will this cause client timeout frequently?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services