[jira] [Commented] (HIVE-13051) Deadline class has numerous issues

["Alexander Kolbasov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-13051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16243439#comment-16243439 ] 

Alexander Kolbasov commented on HIVE-13051:
-------------------------------------------

[~sershe] What is the point of this loop in your patch?

{code}
do {
      deadline.startTime = System.nanoTime();
    } while (deadline.startTime == NO_DEADLINE);
{code}


> Deadline class has numerous issues
> ----------------------------------
>
>                 Key: HIVE-13051
>                 URL: https://issues.apache.org/jira/browse/HIVE-13051
>             Project: Hive
>          Issue Type: Bug
>          Components: Metastore
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>             Fix For: 1.3.0, 2.0.1, 2.1.0
>
>         Attachments: HIVE-13051.01.patch, HIVE-13051.patch
>
>
> currentTimeMillis is not a correct way to measure intervals of time; it can easily be adjusted e.g. by ntpd. System.nanoTime should be used.
> It's also unsafe for failure cases, and doesn't appear to update from config updates correctly.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)