You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by "dev-lpq (via GitHub)" <gi...@apache.org> on 2023/04/12 07:40:36 UTC

[GitHub] [kyuubi] dev-lpq commented on pull request #4690: [K8S][HELM]Define kyuubi labels and improve the RBAC file

dev-lpq commented on PR #4690:
URL: https://github.com/apache/kyuubi/pull/4690#issuecomment-1504810967

   > @dev-lpq thanks for your contribution! Let me leave two general comments:
   > 
   > * Please, create separate PRs for different changes if possible. It helps to review and manage changes.
   > * Please, explain in the PR message `why` the changes are needed instead of `what` is changed.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org