[GitHub] [zookeeper] eolivelli commented on a change in pull request #840: ZOOKEEPER-3143 Pluggable metrics system for ZooKeeper - Data Collection on Server

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #840:  ZOOKEEPER-3143 Pluggable metrics system for ZooKeeper - Data Collection on Server
URL: https://github.com/apache/zookeeper/pull/840#discussion_r262282219
 
 

 ##########
 File path: zookeeper-server/src/test/java/org/apache/zookeeper/test/ResponseCacheTest.java
 ##########
 @@ -48,13 +48,21 @@ public void testResponseCache() throws Exception {
     }
 
     private void checkCacheStatus(long expectedHits, long expectedMisses) {
-        Map<String, Object> metrics = ServerMetrics.getAllValues();
+        
+        Map<String, Object> metrics = new HashMap<>();
 
 Review comment:
   This is the test that needs the DefaultMetricsProvider

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services