[GitHub] [incubator-nuttx] yamt opened a new pull request #4159: tcp_send_buffered.c: Fix broken retransmit

[GitBox <gi...@apache.org>]

yamt opened a new pull request #4159:
URL: https://github.com/apache/incubator-nuttx/pull/4159


   ## Summary
   
   With an applictation using mbedtls, I observed retransmitted segments
   with corrupted user data, detected by the peer tls during mac processing.
   
   Looking at the packet dump, I suspect that a wrb which has been put back
   onto the write_q for retransmission was partially sent but fully acked.
   Note: it's normal for a retransmission to be acked before sent.
   
   In that case, the bug fixed in this commit would cause the wrb have
   a wrong sequence number, possibly the same as the next wrb. It matches
   what I saw in the packet dump. That is, the broken segments contain the
   payload identical to one of the previous segment.
   
   ## Impact
   
   tcp
   
   ## Testing
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #4159: tcp_send_buffered.c: Fix broken retransmit

[GitBox <gi...@apache.org>]

xiaoxiang781216 merged pull request #4159:
URL: https://github.com/apache/incubator-nuttx/pull/4159


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org