You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wink.apache.org by "Bryant Luk (JIRA)" <ji...@apache.org> on 2009/07/14 00:22:15 UTC
[jira] Created: (WINK-83) Singletons should be injected
Singletons should be injected
-----------------------------
Key: WINK-83
URL: https://issues.apache.org/jira/browse/WINK-83
Project: Wink
Issue Type: Bug
Components: Common
Affects Versions: 0.1
Reporter: Bryant Luk
Fix For: 0.1
I believe that objects returned from Application.getSingletons() should still be injected. See JavaDoc for Application.getSingletons().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WINK-83) Singletons should be injected
Posted by "Nadav Fischer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-83?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nadav Fischer reassigned WINK-83:
---------------------------------
Assignee: Nadav Fischer
> Singletons should be injected
> -----------------------------
>
> Key: WINK-83
> URL: https://issues.apache.org/jira/browse/WINK-83
> Project: Wink
> Issue Type: Bug
> Components: Common
> Affects Versions: 0.1
> Reporter: Bryant Luk
> Assignee: Nadav Fischer
> Fix For: 0.1
>
>
> I believe that objects returned from Application.getSingletons() should still be injected. See JavaDoc for Application.getSingletons().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WINK-83) Singletons should be injected
Posted by "Bryant Luk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12730578#action_12730578 ]
Bryant Luk commented on WINK-83:
--------------------------------
Furthermore, should constructor checks be made against classes returned from getSingletons()?
> Singletons should be injected
> -----------------------------
>
> Key: WINK-83
> URL: https://issues.apache.org/jira/browse/WINK-83
> Project: Wink
> Issue Type: Bug
> Components: Common
> Affects Versions: 0.1
> Reporter: Bryant Luk
> Fix For: 0.1
>
>
> I believe that objects returned from Application.getSingletons() should still be injected. See JavaDoc for Application.getSingletons().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WINK-83) Singletons should be injected
Posted by "Nadav Fischer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-83?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nadav Fischer resolved WINK-83.
-------------------------------
Resolution: Fixed
This turned out to be quite the change.
Here's a summary of what was done:
- Added injections of fields and properties to Singletons. This constituted some refactoring of the LifecycleManagers.
- Removed all constructor verification code from AbstractMetadataCollector and surgically placed constructor verification in selected locations only
- Fix and add some unitests
- Changed the name of ClassMetadataPrototypeOF to PrototypeObjectFactory to conform to the other object factories
- Fixed {{ResourceRecordFactory.getRecord(Object)}} method to distinguish between a root resource and a sub-resource
Note that since the constructor validation was removed from the metadata collector, it also provides a fix for WINK-10 so I'll mark that as resolved as well.
> Singletons should be injected
> -----------------------------
>
> Key: WINK-83
> URL: https://issues.apache.org/jira/browse/WINK-83
> Project: Wink
> Issue Type: Bug
> Components: Common
> Affects Versions: 0.1
> Reporter: Bryant Luk
> Assignee: Nadav Fischer
> Fix For: 0.1
>
>
> I believe that objects returned from Application.getSingletons() should still be injected. See JavaDoc for Application.getSingletons().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WINK-83) Singletons should be injected
Posted by "Nadav Fischer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12730706#action_12730706 ]
Nadav Fischer commented on WINK-83:
-----------------------------------
I don't think constructor checks are necessary, the singletons are created by the user. I believe it is analogous to a resource created by a sub-resource locator.
> Singletons should be injected
> -----------------------------
>
> Key: WINK-83
> URL: https://issues.apache.org/jira/browse/WINK-83
> Project: Wink
> Issue Type: Bug
> Components: Common
> Affects Versions: 0.1
> Reporter: Bryant Luk
> Assignee: Nadav Fischer
> Fix For: 0.1
>
>
> I believe that objects returned from Application.getSingletons() should still be injected. See JavaDoc for Application.getSingletons().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WINK-83) Singletons should be injected
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12731309#action_12731309 ]
Hudson commented on WINK-83:
----------------------------
Integrated in Wink-Trunk-JDK1.5 #5 (See [http://hudson.zones.apache.org/hudson/job/Wink-Trunk-JDK1.5/5/])
Fix for Singletons should be injected []
> Singletons should be injected
> -----------------------------
>
> Key: WINK-83
> URL: https://issues.apache.org/jira/browse/WINK-83
> Project: Wink
> Issue Type: Bug
> Components: Common
> Affects Versions: 0.1
> Reporter: Bryant Luk
> Assignee: Nadav Fischer
> Fix For: 0.1
>
>
> I believe that objects returned from Application.getSingletons() should still be injected. See JavaDoc for Application.getSingletons().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (WINK-83) Singletons should be injected
Posted by "Bryant Luk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-83?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryant Luk closed WINK-83.
--------------------------
Thanks Nadav. This one was a tricky one.
> Singletons should be injected
> -----------------------------
>
> Key: WINK-83
> URL: https://issues.apache.org/jira/browse/WINK-83
> Project: Wink
> Issue Type: Bug
> Components: Common
> Affects Versions: 0.1
> Reporter: Bryant Luk
> Assignee: Nadav Fischer
> Fix For: 0.1
>
>
> I believe that objects returned from Application.getSingletons() should still be injected. See JavaDoc for Application.getSingletons().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.