You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/08/02 12:41:02 UTC
[GitHub] [flink] snuyanzin commented on a diff in pull request #20424: [FLINK-28780][docs] fix incorrect description of function dayofmonth.
snuyanzin commented on code in PR #20424:
URL: https://github.com/apache/flink/pull/20424#discussion_r935536277
##########
docs/data/sql_functions.yml:
##########
@@ -463,7 +463,7 @@ temporal:
- sql: DAYOFYEAR(date)
description: Returns the day of a year (an integer between 1 and 366) from SQL date date. Equivalent to EXTRACT(DOY FROM date). E.g., DAYOFYEAR(DATE '1994-09-27') returns 270.
- sql: DAYOFMONTH
- description: Returns the day of a month (an integer between 1 and 31) from SQL date date. Equivalent to EXTRACT(DAY FROM date). E.g., DAYOFWEEK(DATE '1994-09-27') returns 3.
+ description: Returns the day of a month (an integer between 1 and 31) from SQL date date. Equivalent to EXTRACT(DAY FROM date). E.g., DAYOFMONTH(DATE '1994-09-27') returns 27.
Review Comment:
```suggestion
description: Returns the day of a month (an integer between 1 and 31) from SQL date. Equivalent to EXTRACT(DAY FROM date). E.g., DAYOFMONTH(DATE '1994-09-27') returns 27.
```
probably `date date` also should be fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org