[GitHub] [rocketmq] caigy commented on a change in pull request #3997: [ISSUE #3996] fix the acl content of TopicRequestHeader

[GitBox <gi...@apache.org>]

caigy commented on a change in pull request #3997:
URL: https://github.com/apache/rocketmq/pull/3997#discussion_r831699606



##########
File path: acl/src/main/java/org/apache/rocketmq/acl/common/AclClientRPCHook.java
##########
@@ -69,7 +72,11 @@ public void doAfterResponse(String remoteAddr, RemotingCommand request, Remoting
             if (null != header) {
                 Field[] fields = fieldCache.get(header.getClass());
                 if (null == fields) {
-                    fields = header.getClass().getDeclaredFields();
+                    Set<Field> fieldList = new HashSet<Field>();

Review comment:
       `parseRequestContent` is used for signature checks, so the order of fields matters. I think a sorted set should be adopted here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org