You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/07/30 18:53:59 UTC
[GitHub] [geode] sabbeyPivotal opened a new pull request #5416: GEODE-8382: Run Redis tests against Redis API for Geode
sabbeyPivotal opened a new pull request #5416:
URL: https://github.com/apache/geode/pull/5416
We would like to run Redis's tests against Redis API for Geode. Tests will run a separate job in the PR and main pipelines. It has been included in the 'tests' jinja variables.
Co-authored-by: Murtuza Boxwala <mb...@pivotal.io>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] onichols-pivotal commented on a change in pull request #5416: GEODE-8382: Run Redis tests against Redis API for Geode
Posted by GitBox <gi...@apache.org>.
onichols-pivotal commented on a change in pull request #5416:
URL: https://github.com/apache/geode/pull/5416#discussion_r464647336
##########
File path: ci/scripts/execute_redis_tests.sh
##########
@@ -0,0 +1,51 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+cd ..
+git clone --config transfer.fsckObjects=false https://github.com/prettyClouds/redis.git
Review comment:
would a comment be appropriate here explaining why a personal fork is being used and the plan/timeline for eliminating dependency on a personal fork?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] moleske commented on pull request #5416: GEODE-8382: Run Redis tests against Redis API for Geode
Posted by GitBox <gi...@apache.org>.
moleske commented on pull request #5416:
URL: https://github.com/apache/geode/pull/5416#issuecomment-666964959
The pipeline linked is not publicly viewable, so it is harder to assert that it is indeed working
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] sabbeyPivotal commented on a change in pull request #5416: GEODE-8382: Run Redis tests against Redis API for Geode
Posted by GitBox <gi...@apache.org>.
sabbeyPivotal commented on a change in pull request #5416:
URL: https://github.com/apache/geode/pull/5416#discussion_r464665333
##########
File path: ci/pipelines/shared/jinja.variables.yml
##########
@@ -140,6 +140,19 @@ tests:
PLATFORM: linux
RAM: '210'
name: Upgrade
+- ARTIFACT_SLUG: redistests
+ CALL_STACK_TIMEOUT: '1200'
+ CPUS: '4'
+ DUNIT_PARALLEL_FORKS: '0'
+ EXECUTE_TEST_TIMEOUT: 30m
+ GRADLE_TASK: ':geode-redis:redisAPITest'
+ MAX_IN_FLIGHT: 1
+ ONLY_JDK: 11
+ PARALLEL_DUNIT: 'false'
+ PARALLEL_GRADLE: 'true'
+ PLATFORM: linux
+ RAM: '16'
Review comment:
just changed it!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] sabbeyPivotal commented on a change in pull request #5416: GEODE-8382: Run Redis tests against Redis API for Geode
Posted by GitBox <gi...@apache.org>.
sabbeyPivotal commented on a change in pull request #5416:
URL: https://github.com/apache/geode/pull/5416#discussion_r464665951
##########
File path: ci/scripts/execute_redis_tests.sh
##########
@@ -0,0 +1,51 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+cd ..
+git clone --config transfer.fsckObjects=false https://github.com/prettyClouds/redis.git
+cd redis
+git checkout tests-geode-redis
+
+JAVA_HOME="/usr/lib/jvm/java-11-openjdk-amd64" \
Review comment:
I updated this, but I'm wondering if we'll have access to the JAVA_TEST_PATH variable in this script? Attempting to check it now...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] onichols-pivotal commented on a change in pull request #5416: GEODE-8382: Run Redis tests against Redis API for Geode
Posted by GitBox <gi...@apache.org>.
onichols-pivotal commented on a change in pull request #5416:
URL: https://github.com/apache/geode/pull/5416#discussion_r465158361
##########
File path: ci/scripts/execute_redis_tests.sh
##########
@@ -0,0 +1,51 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+cd ..
+git clone --config transfer.fsckObjects=false https://github.com/prettyClouds/redis.git
+cd redis
+git checkout tests-geode-redis
+
+JAVA_HOME="/usr/lib/jvm/java-11-openjdk-amd64" \
Review comment:
If Robert were around today he might know a way to get it from gradle's testJVM property when gradle invokes the redis script, but this works too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] sabbeyPivotal commented on pull request #5416: GEODE-8382: Run Redis tests against Redis API for Geode
Posted by GitBox <gi...@apache.org>.
sabbeyPivotal commented on pull request #5416:
URL: https://github.com/apache/geode/pull/5416#issuecomment-668168119
@smgoller @rhoughton-pivot @onichols-pivotal @dickcav
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] onichols-pivotal commented on a change in pull request #5416: GEODE-8382: Run Redis tests against Redis API for Geode
Posted by GitBox <gi...@apache.org>.
onichols-pivotal commented on a change in pull request #5416:
URL: https://github.com/apache/geode/pull/5416#discussion_r464644167
##########
File path: ci/scripts/execute_redis_tests.sh
##########
@@ -0,0 +1,51 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+cd ..
+git clone --config transfer.fsckObjects=false https://github.com/prettyClouds/redis.git
+cd redis
+git checkout tests-geode-redis
+
+JAVA_HOME="/usr/lib/jvm/java-11-openjdk-amd64" \
Review comment:
you should not need to hardcode the JDK path. The JDK you should be using is passed to you as `${JAVA_TEST_PATH}` (see ci/scripts/execute_tests.sh)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] sabbeyPivotal commented on a change in pull request #5416: GEODE-8382: Run Redis tests against Redis API for Geode
Posted by GitBox <gi...@apache.org>.
sabbeyPivotal commented on a change in pull request #5416:
URL: https://github.com/apache/geode/pull/5416#discussion_r464665517
##########
File path: ci/scripts/execute_redis_tests.sh
##########
@@ -0,0 +1,51 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+cd ..
+git clone --config transfer.fsckObjects=false https://github.com/prettyClouds/redis.git
+cd redis
+git checkout tests-geode-redis
+
+JAVA_HOME="/usr/lib/jvm/java-11-openjdk-amd64" \
+../geode-assembly/build/install/apache-geode/bin/gfsh start server \
+ --J=-Denable-redis-unsupported-commands=true \
+ --name=server1 \
+ --redis-port=6380 \
+ --redis-bind-address=127.0.0.1 \
+ --redis-password=foobar
+
+failCount=0
+
+./runtest --host 127.0.0.1 --port 6380 --single unit/auth
+
+((failCount+=$?))
+
+JAVA_HOME="/usr/lib/jvm/java-11-openjdk-amd64" \
+../geode-assembly/build/install/apache-geode/bin/gfsh start server \
+ --J=-Denable-redis-unsupported-commands=true \
+ --name=server2 \
+ --server-port=0 \
+ --redis-port=6379 \
+ --redis-bind-address=127.0.0.1
+
+./runtest --host 127.0.0.1 --port 6379 --single unit/type/set --single unit/expire
+
+((failCount+=$?))
+
+exit $failCount
Review comment:
sweet, thanks for double checking!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] sabbeyPivotal commented on a change in pull request #5416: GEODE-8382: Run Redis tests against Redis API for Geode
Posted by GitBox <gi...@apache.org>.
sabbeyPivotal commented on a change in pull request #5416:
URL: https://github.com/apache/geode/pull/5416#discussion_r464665951
##########
File path: ci/scripts/execute_redis_tests.sh
##########
@@ -0,0 +1,51 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+cd ..
+git clone --config transfer.fsckObjects=false https://github.com/prettyClouds/redis.git
+cd redis
+git checkout tests-geode-redis
+
+JAVA_HOME="/usr/lib/jvm/java-11-openjdk-amd64" \
Review comment:
Good call. I just updated it and exported the JAVA_HOME variable, definitely check it over and make sure it looks correct.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] onichols-pivotal commented on a change in pull request #5416: GEODE-8382: Run Redis tests against Redis API for Geode
Posted by GitBox <gi...@apache.org>.
onichols-pivotal commented on a change in pull request #5416:
URL: https://github.com/apache/geode/pull/5416#discussion_r465158361
##########
File path: ci/scripts/execute_redis_tests.sh
##########
@@ -0,0 +1,51 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+cd ..
+git clone --config transfer.fsckObjects=false https://github.com/prettyClouds/redis.git
+cd redis
+git checkout tests-geode-redis
+
+JAVA_HOME="/usr/lib/jvm/java-11-openjdk-amd64" \
Review comment:
If Robert were around today he might know a way to get it from gradle's testJVM property when gradle invokes the redis script, but this might work too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] sabbeyPivotal commented on a change in pull request #5416: GEODE-8382: Run Redis tests against Redis API for Geode
Posted by GitBox <gi...@apache.org>.
sabbeyPivotal commented on a change in pull request #5416:
URL: https://github.com/apache/geode/pull/5416#discussion_r464666362
##########
File path: ci/scripts/execute_redis_tests.sh
##########
@@ -0,0 +1,51 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+cd ..
+git clone --config transfer.fsckObjects=false https://github.com/prettyClouds/redis.git
Review comment:
Just added a comment. Let me know if you think it explains the situation sufficiently.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] onichols-pivotal commented on a change in pull request #5416: GEODE-8382: Run Redis tests against Redis API for Geode
Posted by GitBox <gi...@apache.org>.
onichols-pivotal commented on a change in pull request #5416:
URL: https://github.com/apache/geode/pull/5416#discussion_r464644167
##########
File path: ci/scripts/execute_redis_tests.sh
##########
@@ -0,0 +1,51 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+cd ..
+git clone --config transfer.fsckObjects=false https://github.com/prettyClouds/redis.git
+cd redis
+git checkout tests-geode-redis
+
+JAVA_HOME="/usr/lib/jvm/java-11-openjdk-amd64" \
Review comment:
rather than hardcoding the JDK path, please use JAVA_HOME at this point, as you've already configured `ONLY_JDK: 11` and ci/scripts/execute_tests.sh sets up JAVA_HOME for the heavy lifter already
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] rhoughton-pivot commented on a change in pull request #5416: GEODE-8382: Run Redis tests against Redis API for Geode
Posted by GitBox <gi...@apache.org>.
rhoughton-pivot commented on a change in pull request #5416:
URL: https://github.com/apache/geode/pull/5416#discussion_r464641006
##########
File path: ci/scripts/execute_redis_tests.sh
##########
@@ -0,0 +1,51 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+cd ..
+git clone --config transfer.fsckObjects=false https://github.com/prettyClouds/redis.git
+cd redis
+git checkout tests-geode-redis
+
+JAVA_HOME="/usr/lib/jvm/java-11-openjdk-amd64" \
+../geode-assembly/build/install/apache-geode/bin/gfsh start server \
+ --J=-Denable-redis-unsupported-commands=true \
+ --name=server1 \
+ --redis-port=6380 \
+ --redis-bind-address=127.0.0.1 \
+ --redis-password=foobar
+
+failCount=0
+
+./runtest --host 127.0.0.1 --port 6380 --single unit/auth
+
+((failCount+=$?))
+
+JAVA_HOME="/usr/lib/jvm/java-11-openjdk-amd64" \
+../geode-assembly/build/install/apache-geode/bin/gfsh start server \
+ --J=-Denable-redis-unsupported-commands=true \
+ --name=server2 \
+ --server-port=0 \
+ --redis-port=6379 \
+ --redis-bind-address=127.0.0.1
+
+./runtest --host 127.0.0.1 --port 6379 --single unit/type/set --single unit/expire
+
+((failCount+=$?))
+
+exit $failCount
Review comment:
I saw that this does fail-red when the count != 0. Looks good.
##########
File path: ci/pipelines/shared/jinja.variables.yml
##########
@@ -140,6 +140,19 @@ tests:
PLATFORM: linux
RAM: '210'
name: Upgrade
+- ARTIFACT_SLUG: redistests
+ CALL_STACK_TIMEOUT: '1200'
+ CPUS: '4'
+ DUNIT_PARALLEL_FORKS: '0'
+ EXECUTE_TEST_TIMEOUT: 30m
+ GRADLE_TASK: ':geode-redis:redisAPITest'
+ MAX_IN_FLIGHT: 1
+ ONLY_JDK: 11
+ PARALLEL_DUNIT: 'false'
+ PARALLEL_GRADLE: 'true'
+ PLATFORM: linux
+ RAM: '16'
Review comment:
I looked at the resource usage for this heavy lifter, and we can safely take this down to 8GB ram, easy.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] onichols-pivotal commented on a change in pull request #5416: GEODE-8382: Run Redis tests against Redis API for Geode
Posted by GitBox <gi...@apache.org>.
onichols-pivotal commented on a change in pull request #5416:
URL: https://github.com/apache/geode/pull/5416#discussion_r464646511
##########
File path: ci/scripts/execute_redis_tests.sh
##########
@@ -0,0 +1,51 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+cd ..
+git clone --config transfer.fsckObjects=false https://github.com/prettyClouds/redis.git
+cd redis
+git checkout tests-geode-redis
+
+JAVA_HOME="/usr/lib/jvm/java-11-openjdk-amd64" \
+../geode-assembly/build/install/apache-geode/bin/gfsh start server \
+ --J=-Denable-redis-unsupported-commands=true \
+ --name=server1 \
+ --redis-port=6380 \
+ --redis-bind-address=127.0.0.1 \
+ --redis-password=foobar
+
+failCount=0
+
+./runtest --host 127.0.0.1 --port 6380 --single unit/auth
+
+((failCount+=$?))
+
+JAVA_HOME="/usr/lib/jvm/java-11-openjdk-amd64" \
Review comment:
redundant as you have already set JAVA_HOME above
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] rhoughton-pivot merged pull request #5416: GEODE-8382: Run Redis tests against Redis API for Geode
Posted by GitBox <gi...@apache.org>.
rhoughton-pivot merged pull request #5416:
URL: https://github.com/apache/geode/pull/5416
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] sabbeyPivotal commented on a change in pull request #5416: GEODE-8382: Run Redis tests against Redis API for Geode
Posted by GitBox <gi...@apache.org>.
sabbeyPivotal commented on a change in pull request #5416:
URL: https://github.com/apache/geode/pull/5416#discussion_r465148577
##########
File path: ci/scripts/execute_redis_tests.sh
##########
@@ -0,0 +1,51 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+cd ..
+git clone --config transfer.fsckObjects=false https://github.com/prettyClouds/redis.git
+cd redis
+git checkout tests-geode-redis
+
+JAVA_HOME="/usr/lib/jvm/java-11-openjdk-amd64" \
Review comment:
Just pushed an update to execute_tests.sh that sets the JAVA_TEST_PATH variable so it's accessible inside the execute_redis_tests script. It passes here: https://concourse.gemfire-ci.info/teams/developer/pipelines/sabbeypivotal-new-pr-pr/jobs/RedisTestOpenJDK11/builds/6
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] sabbeyPivotal commented on pull request #5416: GEODE-8382: Run Redis tests against Redis API for Geode
Posted by GitBox <gi...@apache.org>.
sabbeyPivotal commented on pull request #5416:
URL: https://github.com/apache/geode/pull/5416#issuecomment-667115984
> The pipeline linked is not publicly viewable, so it is harder to assert that it is indeed working
Good point, Mike. The pipeline was tested locally, feel free to deploy a local version to make sure it works.
DUnit failure is unrelated to this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] sabbeyPivotal commented on pull request #5416: GEODE-8382: Run Redis tests against Redis API for Geode
Posted by GitBox <gi...@apache.org>.
sabbeyPivotal commented on pull request #5416:
URL: https://github.com/apache/geode/pull/5416#issuecomment-666602055
Tested new pipeline job here: https://concourse.gemfire-ci.info/teams/developer/pipelines/sabbeypivotal-pipelining-pr
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] sabbeyPivotal commented on a change in pull request #5416: GEODE-8382: Run Redis tests against Redis API for Geode
Posted by GitBox <gi...@apache.org>.
sabbeyPivotal commented on a change in pull request #5416:
URL: https://github.com/apache/geode/pull/5416#discussion_r464666188
##########
File path: ci/scripts/execute_redis_tests.sh
##########
@@ -0,0 +1,51 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+cd ..
+git clone --config transfer.fsckObjects=false https://github.com/prettyClouds/redis.git
+cd redis
+git checkout tests-geode-redis
+
+JAVA_HOME="/usr/lib/jvm/java-11-openjdk-amd64" \
+../geode-assembly/build/install/apache-geode/bin/gfsh start server \
+ --J=-Denable-redis-unsupported-commands=true \
+ --name=server1 \
+ --redis-port=6380 \
+ --redis-bind-address=127.0.0.1 \
+ --redis-password=foobar
+
+failCount=0
+
+./runtest --host 127.0.0.1 --port 6380 --single unit/auth
+
+((failCount+=$?))
+
+JAVA_HOME="/usr/lib/jvm/java-11-openjdk-amd64" \
Review comment:
Just exported the variable and was able to remove this. Thanks for the suggestion!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org