You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by shazron <gi...@git.apache.org> on 2016/10/05 18:08:36 UTC
[GitHub] cordova-ios pull request #262: CB-11957 - Update docs for remote/local notif...
GitHub user shazron opened a pull request:
https://github.com/apache/cordova-ios/pull/262
CB-11957 - Update docs for remote/local notifications removed in cordova-ios-4.0
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shazron/cordova-ios CB-11957
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-ios/pull/262.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #262
----
commit 2e60a72bbfceecd3064246d71159f9ed1c24c2af
Author: Shazron Abdullah <sh...@apache.org>
Date: 2016-10-05T18:07:42Z
CB-11957 - Update docs for remote/local notifications removed in cordova-ios-4.0
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request #262: CB-11957 - Update docs for remote/local notif...
Posted by dpogue <gi...@git.apache.org>.
Github user dpogue commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/262#discussion_r82043239
--- Diff: CordovaLib/Classes/Public/CDVPlugin.h ---
@@ -44,6 +41,17 @@ extern NSString* const CDVViewWillLayoutSubviewsNotification;
extern NSString* const CDVViewDidLayoutSubviewsNotification;
extern NSString* const CDVViewWillTransitionToSizeNotification;
+/*
+ * The local and remote push notification functionality has been removed from the core in cordova-ios 4.x,
+ * but these constants have unfortunately have not been removed, but will be removed in 5.x.
+ *
+ * To have the same functionality in 3.x, use a third-party plugin or the experimental
--- End diff --
s/in 3.x/as 3.x/ ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request #262: CB-11957 - Update docs for remote/local notif...
Posted by shazron <gi...@git.apache.org>.
Github user shazron closed the pull request at:
https://github.com/apache/cordova-ios/pull/262
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #262: CB-11957 - Update docs for remote/local notification...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/262
Merged https://github.com/apache/cordova-ios/commit/636113f047ee2c7dae742dff2beafae2121ceb62
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #262: CB-11957 - Update docs for remote/local notification...
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-ios/pull/262
## [Current coverage](https://codecov.io/gh/apache/cordova-ios/pull/262?src=pr) is 56.68% (diff: 100%)
> Merging [#262](https://codecov.io/gh/apache/cordova-ios/pull/262?src=pr) into [master](https://codecov.io/gh/apache/cordova-ios/branch/master?src=pr) will not change coverage
```diff
@@ master #262 diff @@
==========================================
Files 12 12
Lines 1226 1226
Methods 197 197
Messages 0 0
Branches 192 192
==========================================
Hits 695 695
Misses 531 531
Partials 0 0
```
> Powered by [Codecov](https://codecov.io?src=pr). Last update [0231fcb...2e60a72](https://codecov.io/gh/apache/cordova-ios/compare/0231fcbd159258eb9a22fa7c5a1bc0bd527c9e3d...2e60a72bbfceecd3064246d71159f9ed1c24c2af?src=pr)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request #262: CB-11957 - Update docs for remote/local notif...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/262#discussion_r82043482
--- Diff: CordovaLib/Classes/Public/CDVPlugin.h ---
@@ -44,6 +41,17 @@ extern NSString* const CDVViewWillLayoutSubviewsNotification;
extern NSString* const CDVViewDidLayoutSubviewsNotification;
extern NSString* const CDVViewWillTransitionToSizeNotification;
+/*
+ * The local and remote push notification functionality has been removed from the core in cordova-ios 4.x,
+ * but these constants have unfortunately have not been removed, but will be removed in 5.x.
+ *
+ * To have the same functionality in 3.x, use a third-party plugin or the experimental
--- End diff --
Oops, yup, as :) thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org