You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@griffin.apache.org by GitBox <gi...@apache.org> on 2019/12/17 15:25:23 UTC
[GitHub] [griffin] chitralverma opened a new pull request #560: [WIP]
[GRIFFIN-312] Code Style Standardization
chitralverma opened a new pull request #560: [WIP] [GRIFFIN-312] Code Style Standardization
URL: https://github.com/apache/griffin/pull/560
**What changes were proposed in this pull request?**
This PR targets the following,
- fix the various warnings during build and in source code,
- perform code formatting as per a standard style,
- fix scalastyle integration
Using the [code format from spark code style can be automatically imposed on measure module. Link: https://github.com/apache/spark/blob/master/dev/.scalafmt.conf
Since ScalaStyle targets scala source code only, it should be a part of the measure module only. Current misconfiguration is also suppressing the formatting errors
Scalafmt is used for code formatting.
**Does this PR introduce any user-facing change?**
No
**How was this patch tested?**
Griffin test suite.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services