You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/19 13:15:35 UTC

[GitHub] [flink] dannycranmer opened a new pull request #13689: [FLINK-19716][Kinesis][EFO] Unable to use Assume Role with EFO 

dannycranmer opened a new pull request #13689:
URL: https://github.com/apache/flink/pull/13689


   ## What is the purpose of the change
   
   Consuming from Kinesis using EFO fails with Assume Role credential provider. The following error is encountered:
   - `Caused by: org.apache.flink.kinesis.shaded.software.amazon.awssdk.core.exception.SdkClientException: Unable to load an HTTP implementation from any provider in the chain. You must declare a dependency on an appropriate HTTP implementation or pass in an SdkHttpClient explicitly to the client builder.`
   
   ## Brief change log
   
   * Add a service manifest such that the shaded HTTP client is used
   * Update the shaded HTTP client/core version used by Kinesis connector due to incompatibilities with existing versions
   
   ## Verifying this change
   
   - This change was verified manually since:
     - The unit tests do not/should not contact AWS
     - This is a configuration/dependency upgrade only change 
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): yes
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not documented (not a feature)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13689: [FLINK-19716][Kinesis][EFO] Unable to use Assume Role with EFO

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13689:
URL: https://github.com/apache/flink/pull/13689#issuecomment-712159911


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "aeb8ef76495e26ed0c9c77a57bd53d8ce5340960",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7869",
       "triggerID" : "aeb8ef76495e26ed0c9c77a57bd53d8ce5340960",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * aeb8ef76495e26ed0c9c77a57bd53d8ce5340960 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7869) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] asfgit closed pull request #13689: [FLINK-19716][Kinesis][EFO] Unable to use Assume Role with EFO

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #13689:
URL: https://github.com/apache/flink/pull/13689


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #13689: [FLINK-19716][Kinesis][EFO] Unable to use Assume Role with EFO

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13689:
URL: https://github.com/apache/flink/pull/13689#issuecomment-712159911


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "aeb8ef76495e26ed0c9c77a57bd53d8ce5340960",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "aeb8ef76495e26ed0c9c77a57bd53d8ce5340960",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * aeb8ef76495e26ed0c9c77a57bd53d8ce5340960 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13689: [FLINK-19716][Kinesis][EFO] Unable to use Assume Role with EFO

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13689:
URL: https://github.com/apache/flink/pull/13689#issuecomment-712159911


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "aeb8ef76495e26ed0c9c77a57bd53d8ce5340960",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7869",
       "triggerID" : "aeb8ef76495e26ed0c9c77a57bd53d8ce5340960",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * aeb8ef76495e26ed0c9c77a57bd53d8ce5340960 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7869) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] tzulitai commented on pull request #13689: [FLINK-19716][Kinesis][EFO] Unable to use Assume Role with EFO

Posted by GitBox <gi...@apache.org>.
tzulitai commented on pull request #13689:
URL: https://github.com/apache/flink/pull/13689#issuecomment-712596039


   LGTM, thanks for fixing this @dannycranmer! Merging this now ...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #13689: [FLINK-19716][Kinesis][EFO] Unable to use Assume Role with EFO

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13689:
URL: https://github.com/apache/flink/pull/13689#issuecomment-712150154


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit aeb8ef76495e26ed0c9c77a57bd53d8ce5340960 (Mon Oct 19 13:18:15 UTC 2020)
   
   **Warnings:**
    * **1 pom.xml files were touched**: Check for build and licensing issues.
    * No documentation files were touched! Remember to keep the Flink docs up to date!
    * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-19716).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org