You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by ya...@apache.org on 2019/10/10 03:43:11 UTC

[servicecomb-java-chassis] branch master updated: [SCB-1388]test on "handler-loadbalance" project, cannot all success (#1313)

This is an automated email from the ASF dual-hosted git repository.

yaohaishi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/servicecomb-java-chassis.git


The following commit(s) were added to refs/heads/master by this push:
     new 6f7743e  [SCB-1388]test on "handler-loadbalance" project,cannot all success (#1313)
6f7743e is described below

commit 6f7743e809416d6ae1065f3b79c85450b8efab75
Author: ltp217 <86...@qq.com>
AuthorDate: Thu Oct 10 11:43:06 2019 +0800

    [SCB-1388]test on "handler-loadbalance" project,cannot all success (#1313)
    
    * [SCB-1388]test on "handler-loadbalance" project,cannot all success
    
    * [SCB-1388]test on "handler-loadbalance" project,cannot all success
---
 .../apache/servicecomb/loadbalance/LoadbalanceHandler.java    |  2 +-
 .../servicecomb/loadbalance/TestLoadBalanceHandler2.java      | 11 +++--------
 2 files changed, 4 insertions(+), 9 deletions(-)

diff --git a/handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/LoadbalanceHandler.java b/handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/LoadbalanceHandler.java
index ae4456e..df7424a 100644
--- a/handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/LoadbalanceHandler.java
+++ b/handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/LoadbalanceHandler.java
@@ -71,7 +71,7 @@ public class LoadbalanceHandler implements Handler {
 
   public static final String SERVICECOMB_SERVER_ENDPOINT = "scb-endpoint";
 
-  public static final boolean supportDefinedEndpoint =
+  public final boolean supportDefinedEndpoint =
       DynamicPropertyFactory.getInstance()
           .getBooleanProperty("servicecomb.loadbalance.userDefinedEndpoint.enabled", false).get();
 
diff --git a/handlers/handler-loadbalance/src/test/java/org/apache/servicecomb/loadbalance/TestLoadBalanceHandler2.java b/handlers/handler-loadbalance/src/test/java/org/apache/servicecomb/loadbalance/TestLoadBalanceHandler2.java
index b76d47c..40b7a67 100644
--- a/handlers/handler-loadbalance/src/test/java/org/apache/servicecomb/loadbalance/TestLoadBalanceHandler2.java
+++ b/handlers/handler-loadbalance/src/test/java/org/apache/servicecomb/loadbalance/TestLoadBalanceHandler2.java
@@ -69,17 +69,12 @@ import com.google.common.eventbus.Subscribe;
  *
  */
 public class TestLoadBalanceHandler2 {
-  @BeforeClass
-  public static void beforeClass() {
-    //prepare for defineEndpointAndHandle
-    ArchaiusUtils.setProperty("servicecomb.loadbalance.userDefinedEndpoint.enabled", "true");
-    // avoid mock
-
-  }
-
   @Before
   public void setUp() {
     // clear up load balance stats
+    //prepare for defineEndpointAndHandle
+    ArchaiusUtils.setProperty("servicecomb.loadbalance.userDefinedEndpoint.enabled", "true");
+    // avoid mock
     ServiceCombLoadBalancerStats.INSTANCE.init();
     ServiceCombServerStats.releaseTryingChance();
   }