You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Devaraj K (JIRA)" <ji...@apache.org> on 2015/06/05 11:34:00 UTC

[jira] [Commented] (MAPREDUCE-6350) JobHistory doesn't support fully-functional search

    [ https://issues.apache.org/jira/browse/MAPREDUCE-6350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14574202#comment-14574202 ] 

Devaraj K commented on MAPREDUCE-6350:
--------------------------------------

Thanks [~l201514] for the patch.

Patch mostly looks good except these nits.

1. Can you move the new configuration "mapreduce.jobhistory.jobname.limit" and the default value to JHAdminConfig.java.

{code:xml}
+  private static final int JOB_NAME_TRIM_LENGTH = 50;
{code}

{code:xml}
+        int jobNameLimit =
+            getConfig().getInt("mapreduce.jobhistory.jobname.limit", JOB_NAME_TRIM_LENGTH);
{code}

2. In FileNameIndexUtils.java, can you remove the JOB_NAME_TRIM_LENGTH declaration and access it from JHAdminConfig.java.

3. Please add tests for covering this change.

> JobHistory doesn't support fully-functional search
> --------------------------------------------------
>
>                 Key: MAPREDUCE-6350
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6350
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: jobhistoryserver
>            Reporter: Siqi Li
>            Assignee: Siqi Li
>            Priority: Critical
>         Attachments: MAPREDUCE-6350.v1.patch, YARN-1614.v1.patch, YARN-1614.v2.patch, YARN-1614.v3.patch
>
>
> job history server will only output the first 50 characters of the job names in webUI.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)