You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kylin.apache.org by li...@apache.org on 2017/12/31 13:19:39 UTC
[22/50] [abbrv] kylin git commit: minor,
save a redundant reload in CubeManager.update()
minor, save a redundant reload in CubeManager.update()
Project: http://git-wip-us.apache.org/repos/asf/kylin/repo
Commit: http://git-wip-us.apache.org/repos/asf/kylin/commit/26e191a5
Tree: http://git-wip-us.apache.org/repos/asf/kylin/tree/26e191a5
Diff: http://git-wip-us.apache.org/repos/asf/kylin/diff/26e191a5
Branch: refs/heads/master
Commit: 26e191a52e56a35deab9753138502e02c5d9dc23
Parents: d7ebaec
Author: Li Yang <li...@apache.org>
Authored: Mon Dec 18 14:34:15 2017 +0800
Committer: Hongbin Ma <ma...@kyligence.io>
Committed: Mon Dec 18 14:36:50 2017 +0800
----------------------------------------------------------------------
core-cube/src/main/java/org/apache/kylin/cube/CubeManager.java | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/kylin/blob/26e191a5/core-cube/src/main/java/org/apache/kylin/cube/CubeManager.java
----------------------------------------------------------------------
diff --git a/core-cube/src/main/java/org/apache/kylin/cube/CubeManager.java b/core-cube/src/main/java/org/apache/kylin/cube/CubeManager.java
index 1813ad2..17e3aa5 100755
--- a/core-cube/src/main/java/org/apache/kylin/cube/CubeManager.java
+++ b/core-cube/src/main/java/org/apache/kylin/cube/CubeManager.java
@@ -349,7 +349,7 @@ public class CubeManager implements IRealizationProvider {
}
try {
- crud.save(cube);
+ cube = crud.save(cube);
} catch (IllegalStateException ise) {
logger.warn("Write conflict to update cube " + cube.getName() + " at try " + retry + ", will retry...");
if (retry >= 7) {
@@ -375,7 +375,7 @@ public class CubeManager implements IRealizationProvider {
//this is a duplicate call to take care of scenarios where REST cache service unavailable
ProjectManager.getInstance(cube.getConfig()).clearL2Cache();
- return crud.reload(cube.resourceName());
+ return cube;
}
// for test