[jira] [Commented] (AIRFLOW-4255) Replace discovery based api in Google Cloud Storage Hook with Client based api

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-4255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16811916#comment-16811916 ] 

ASF GitHub Bot commented on AIRFLOW-4255:
-----------------------------------------

kaxil commented on pull request #5054: [AIRFLOW-4255] Replaces Discovery based api with client based for GCS
URL: https://github.com/apache/airflow/pull/5054
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-4255
     - In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   https://cloud.google.com/apis/docs/client-libraries-explained
   
   Google Cloud Client Libraries use our latest client library model and are our recommended option for accessing Cloud APIs programmatically, where available.
   
   https://pypi.org/project/google-cloud-storage/ library is available and we should be using that.
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   The current tests already cover it
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
   ### Code Quality
   
   - [x] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Replace discovery based api in Google Cloud Storage Hook with Client based api
> ------------------------------------------------------------------------------
>
>                 Key: AIRFLOW-4255
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-4255
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: gcp
>            Reporter: Kaxil Naik
>            Assignee: Kaxil Naik
>            Priority: Minor
>
> https://cloud.google.com/apis/docs/client-libraries-explained
> Google Cloud Client Libraries use our latest client library model and are our recommended option for accessing Cloud APIs programmatically, where available.
> https://pypi.org/project/google-cloud-storage/ library is available and we should be using that,



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)