You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by "bbeaudreault (via GitHub)" <gi...@apache.org> on 2023/06/05 22:00:34 UTC

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #5257: HBASE-27890 Expose a getter on Connection/AsyncConnection for getting…

bbeaudreault commented on code in PR #5257:
URL: https://github.com/apache/hbase/pull/5257#discussion_r1218639641


##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnectionSnapshot.java:
##########


Review Comment:
   I'm also wondering if we want to try to avoid exposing the codahale metrics Snapshot directly? It might make compatibility tricky in the future, if the upstream api there changes? Just a thought



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org