[Impala-ASF-CR] IMPALA-11408: Fill missing partition columns with NULL when INSERT INTO iceberg tbl (col list)

["Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>]

Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18790 )

Change subject: IMPALA-11408: Fill missing partition columns with NULL when INSERT INTO iceberg_tbl (col_list)
......................................................................


Patch Set 2:

(1 comment)

Thanks for working on this.

http://gerrit.cloudera.org:8080/#/c/18790/2/fe/src/main/java/org/apache/impala/analysis/InsertStmt.java
File fe/src/main/java/org/apache/impala/analysis/InsertStmt.java:

http://gerrit.cloudera.org:8080/#/c/18790/2/fe/src/main/java/org/apache/impala/analysis/InsertStmt.java@907
PS2, Line 907:       Preconditions.checkState(partitionKeyExprs_.size() == parts);
We can also make things work by only removing this precondition check because at L950 we'll add NULL literals for missing columns.

The data file will be created directly under the table/data directory, but the Iceberg metadata will be correct and this is what really matters. Or maybe we could investigate why the partition directory is not being generated.

Though we might need some other checks, i.e. we should only do that if there's a column permutation in the INSERT stmt and there are no missing columns. Otherwise `partitionKeyExprs_.size() == parts` should be true.



-- 
To view, visit http://gerrit.cloudera.org:8080/18790
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I40c733755d65e5c81a12ffe09b6d16ed5d115368
Gerrit-Change-Number: 18790
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 04 Aug 2022 17:07:05 +0000
Gerrit-HasComments: Yes