You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jclouds.apache.org by Andrew Bayer <no...@github.com> on 2013/08/02 01:06:44 UTC
[jclouds] JCLOUDS-221. Add availabilityZone to spot price history.
(#96)
You can merge this Pull Request by running:
git pull https://github.com/abayer/jclouds-1 jclouds-221
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/96
-- Commit Summary --
* JCLOUDS-221. Add availabilityZone to spot price history.
-- File Changes --
M providers/aws-ec2/src/main/java/org/jclouds/aws/ec2/domain/Spot.java (28)
M providers/aws-ec2/src/main/java/org/jclouds/aws/ec2/xml/SpotHandler.java (2)
M providers/aws-ec2/src/test/java/org/jclouds/aws/ec2/xml/DescribeSpotPriceHistoryResponseHandlerTest.java (15)
M providers/aws-ec2/src/test/resources/describe_spot_price_history.xml (3)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/96.patch
https://github.com/jclouds/jclouds/pull/96.diff
Re: [jclouds] JCLOUDS-221. Add availabilityZone to spot price
history. (#96)
Posted by Andrew Phillips <no...@github.com>.
> @@ -71,8 +73,13 @@ public Builder timestamp(Date timestamp) {
> return this;
> }
>
> + public Builder availabilityZone(String availabilityZone) {
> + this.availabilityZone = availabilityZone;
> + return this;
> +
Delete empty line?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/96/files#r5543694
Re: [jclouds] JCLOUDS-221. Add availabilityZone to spot price
history. (#96)
Posted by Andrew Bayer <no...@github.com>.
Closed #96.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/96
Re: [jclouds] JCLOUDS-221. Add availabilityZone to spot price
history. (#96)
Posted by Andrew Phillips <no...@github.com>.
Pending BuildHive et al, looks good to me!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/96#issuecomment-21976963
Re: [jclouds] JCLOUDS-221. Add availabilityZone to spot price
history. (#96)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #106](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/106/) UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/96#issuecomment-21980353
Re: [jclouds] JCLOUDS-221. Add availabilityZone to spot price
history. (#96)
Posted by Andrew Bayer <no...@github.com>.
> @@ -71,8 +73,13 @@ public Builder timestamp(Date timestamp) {
> return this;
> }
>
> + public Builder availabilityZone(String availabilityZone) {
> + this.availabilityZone = availabilityZone;
> + return this;
> +
Yeah, that's dumb. Fixing!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/96/files#r5543725
Re: [jclouds] JCLOUDS-221. Add availabilityZone to spot price
history. (#96)
Posted by Andrew Bayer <no...@github.com>.
Pretty sure that's transient weird. Ignoring and pushing. =)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/96#issuecomment-21980449
Re: [jclouds] JCLOUDS-221. Add availabilityZone to spot price
history. (#96)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #563](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/563/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/96#issuecomment-21979510
Re: [jclouds] JCLOUDS-221. Add availabilityZone to spot price
history. (#96)
Posted by BuildHive <no...@github.com>.
[jclouds ยป jclouds #266](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/266/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/96#issuecomment-21980077
Re: [jclouds] JCLOUDS-221. Add availabilityZone to spot price
history. (#96)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #562](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/562/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/96#issuecomment-21978687