You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2021/08/13 07:55:39 UTC

[GitHub] [guacamole-client] petzsch commented on a change in pull request #615: GUACAMOLE-1322: Include SAML Plugin in Docker Image

petzsch commented on a change in pull request #615:
URL: https://github.com/apache/guacamole-client/pull/615#discussion_r688319243



##########
File path: guacamole-docker/bin/start.sh
##########
@@ -830,6 +870,12 @@ if [ -n "$OPENID_AUTHORIZATION_ENDPOINT" ]; then
     INSTALLED_AUTH="$INSTALLED_AUTH openid"
 fi
 
+# Use SAML if specified
+if [ -n "$SAML_IDP_METADATA_URL" ]; then

Review comment:
       > [...]if the metadata XML is incomplete
   
   That will be hard to check from within a bash script as I would need to parse the content of saml-idp-metadata-url to check for what is missing and if it is present in the other variables.
   
   Can't really say when I will get to this. If someone else wants to make the needed changes and needs permissions on my fork, simply let me know.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org