You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/04/15 08:53:24 UTC

[GitHub] [iotdb] zhanglingzhe0820 opened a new pull request #3013: [IOTDB-1294] Compaction mods for new mods structure

zhanglingzhe0820 opened a new pull request #3013:
URL: https://github.com/apache/iotdb/pull/3013


   ## Behavior
   Delete operation become invalid after compaction.
   
   ## Reason
   As we change the structure of mods file in 0.12 (delete `version` and change it to `tsfileOffset` which means that only if the offset of the chunk <= `tsfileOffset`, then the modification record is valid). However, the position of chunk in tsfile may change after compaction.
   
   ## Solution
   Update the `tsfileOffset` of remain modification record to Long.MAX_VALUE, which means that it will be valid for the whole file.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] SilverNarcissus merged pull request #3013: [IOTDB-1294] Compaction mods for new mods structure

Posted by GitBox <gi...@apache.org>.

SilverNarcissus merged pull request #3013:
URL: https://github.com/apache/iotdb/pull/3013


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] zhanglingzhe0820 commented on pull request #3013: [IOTDB-1294] Compaction mods for new mods structure

Posted by GitBox <gi...@apache.org>.

zhanglingzhe0820 commented on pull request #3013:
URL: https://github.com/apache/iotdb/pull/3013#issuecomment-824569108


   cherry pick to 0.12 by [PR](https://github.com/apache/iotdb/pull/3046)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org