Re: [PR] [LOG4J2-3047] Check urlConnection for being instance of JarURLConnection instead of relying on protocol name (logging-log4j2)

["jglick (via GitHub)" <gi...@apache.org>]

jglick commented on code in PR #1164:
URL: https://github.com/apache/logging-log4j2/pull/1164#discussion_r1171847447


##########
log4j-core/src/main/java/org/apache/logging/log4j/core/config/ConfigurationSource.java:
##########
@@ -367,7 +357,7 @@ private static ConfigurationSource getConfigurationSource(URL url) {
             try {
                 if (file != null) {
                     return new ConfigurationSource(urlConnection.getInputStream(), FileUtils.fileFromUri(url.toURI()));
-                } else if (JAR.equals(url.getProtocol())) {
+                } else if (urlConnection instanceof JarURLConnection) {

Review Comment:
   https://github.com/openjdk/jdk/pull/12871 should fix this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org