You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2013/08/02 08:13:49 UTC

[jira] [Commented] (HBASE-8699) Parameter to DistributedFileSystem#isFileClosed should be of type Path

    [ https://issues.apache.org/jira/browse/HBASE-8699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13727381#comment-13727381 ] 

Hudson commented on HBASE-8699:
-------------------------------

SUCCESS: Integrated in HBase-0.94-security #240 (See [https://builds.apache.org/job/HBase-0.94-security/240/])
HBASE-8670 [0.94] Backport HBASE-8449,HBASE-8204 and HBASE-8699 to 0.94 (Refactor recoverLease retries and pauses) (enis: rev 1509532)
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/util/FSHDFSUtils.java
* /hbase/branches/0.94/src/main/resources/hbase-default.xml
* /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java
* /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/util/TestFSHDFSUtils.java

                
> Parameter to DistributedFileSystem#isFileClosed should be of type Path
> ----------------------------------------------------------------------
>
>                 Key: HBASE-8699
>                 URL: https://issues.apache.org/jira/browse/HBASE-8699
>             Project: HBase
>          Issue Type: Bug
>          Components: wal
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>             Fix For: 0.98.0, 0.95.2
>
>         Attachments: 8699-v1.txt, 8699-v3.txt, 8699-v4.txt, 8699-v5.txt, 8699-v5.txt
>
>
> Here is current code of FSHDFSUtils#isFileClosed():
> {code}
>   boolean isFileClosed(final DistributedFileSystem dfs, final Path p) {
>     try {
>       Method m = dfs.getClass().getMethod("isFileClosed", new Class<?>[] {String.class});
>       return (Boolean) m.invoke(dfs, p.toString());
> {code}
> We look for isFileClosed method with parameter type of String.
> However, from hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java (branch-2):
> {code}
>   public boolean isFileClosed(Path src) throws IOException {
> {code}
> The parameter type is of Path.
> This means we would get NoSuchMethodException.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira