You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Xiang Li (JIRA)" <ji...@apache.org> on 2019/02/13 16:48:00 UTC

[jira] [Comment Edited] (HBASE-21866) Do not move the table to null rsgroup when creating a existing table

    [ https://issues.apache.org/jira/browse/HBASE-21866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16767375#comment-16767375 ] 

Xiang Li edited comment on HBASE-21866 at 2/13/19 4:47 PM:
-----------------------------------------------------------

Hi [~nihaljain.cs], thanks for the comments! It reminded me of the following similar error in master's log, using the latest master branch, with RSGROUP enabled.
{code}
2019-02-10 03:39:37,290 INFO  [RpcServer.default.FPBQ.Fifo.handler=29,queue=2,port=16000] rsgroup.RSGroupAdminServer: Moving table t1 to RSGroup default
2019-02-10 03:39:37,294 INFO  [RegionOpenAndInitThread-t1-1] regionserver.HRegion: creating HRegion t1 HTD == 't1', {NAME => 'cf1', VERSIONS => '1', EVICT_BLOCKS_ON_CLOSE => 'false', NEW_VERSION_BEHAVIOR => 'false', KEEP_DELETED_CELLS => 'FALSE', CACHE_DATA_ON_WRITE => 'false', DATA_BLOCK_ENCODING => 'NONE', TTL => 'FOREVER', MIN_VERSIONS => '0', REPLICATION_SCOPE => '0', BLOOMFILTER => 'ROW', CACHE_INDEX_ON_WRITE => 'false', IN_MEMORY => 'false', CACHE_BLOOMS_ON_WRITE => 'false', PREFETCH_BLOCKS_ON_OPEN => 'false', COMPRESSION => 'NONE', BLOCKCACHE => 'true', BLOCKSIZE => '65536'} RootDir = file:/home/lixiang/standalonehbase/hbase/.tmp Table name == t1
2019-02-10 03:39:37,296 INFO  [RegionOpenAndInitThread-t1-1] regionserver.HRegion: Closed t1,,1549769977180.df77e6fff94073c0e3b99b22457e3d49.
2019-02-10 03:39:37,299 ERROR [RpcServer.default.FPBQ.Fifo.handler=29,queue=2,port=16000] master.TableStateManager: Unable to get table t1 state
org.apache.hadoop.hbase.master.TableStateManager$TableStateNotFoundException: t1
	at org.apache.hadoop.hbase.master.TableStateManager.getTableState(TableStateManager.java:215)
	at org.apache.hadoop.hbase.master.TableStateManager.isTableState(TableStateManager.java:147)
	at org.apache.hadoop.hbase.master.assignment.AssignmentManager.isTableDisabled(AssignmentManager.java:354)
	at org.apache.hadoop.hbase.rsgroup.RSGroupAdminServer.moveTables(RSGroupAdminServer.java:411)
	at org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint.assignTableToGroup(RSGroupAdminEndpoint.java:471)
	at org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint.postCreateTable(RSGroupAdminEndpoint.java:494)
	at org.apache.hadoop.hbase.master.MasterCoprocessorHost$13.call(MasterCoprocessorHost.java:350)
	at org.apache.hadoop.hbase.master.MasterCoprocessorHost$13.call(MasterCoprocessorHost.java:347)
	at org.apache.hadoop.hbase.coprocessor.CoprocessorHost$ObserverOperationWithoutResult.callObserver(CoprocessorHost.java:551)
	at org.apache.hadoop.hbase.coprocessor.CoprocessorHost.execOperation(CoprocessorHost.java:625)
	at org.apache.hadoop.hbase.master.MasterCoprocessorHost.postCreateTable(MasterCoprocessorHost.java:347)
	at org.apache.hadoop.hbase.master.HMaster$4.run(HMaster.java:2083)
	at org.apache.hadoop.hbase.master.procedure.MasterProcedureUtil.submitProcedure(MasterProcedureUtil.java:134)
	at org.apache.hadoop.hbase.master.HMaster.createTable(HMaster.java:2066)
	at org.apache.hadoop.hbase.master.MasterRpcServices.createTable(MasterRpcServices.java:644)
	at org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java)
	at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413)
	at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130)
	at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324)
	at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304)
2019-02-10 03:39:37,301 INFO  [PEWorker-12] hbase.MetaTableAccessor: Added 1 regions to meta.
2019-02-10 03:39:37,304 INFO  [PEWorker-12] hbase.MetaTableAccessor: Updated tableName=t1, state=ENABLING in hbase:meta
2019-02-10 03:39:37,305 INFO  [RpcServer.default.FPBQ.Fifo.handler=29,queue=2,port=16000] master.MasterRpcServices: Client=lixiang//10.23.10.9 procedure request for creating table: namespace: "default"
qualifier: "t1"
{code}
I will open a new JIRA to track that. 


was (Author: water):
Hi [~nihaljain.cs], thanks for the comments! I think HBASE-19509 seems regressed, because I could see the following error in master's log, using the latest master branch, with RSGROUP enabled.
{code}
2019-02-10 03:39:37,290 INFO  [RpcServer.default.FPBQ.Fifo.handler=29,queue=2,port=16000] rsgroup.RSGroupAdminServer: Moving table t1 to RSGroup default
2019-02-10 03:39:37,294 INFO  [RegionOpenAndInitThread-t1-1] regionserver.HRegion: creating HRegion t1 HTD == 't1', {NAME => 'cf1', VERSIONS => '1', EVICT_BLOCKS_ON_CLOSE => 'false', NEW_VERSION_BEHAVIOR => 'false', KEEP_DELETED_CELLS => 'FALSE', CACHE_DATA_ON_WRITE => 'false', DATA_BLOCK_ENCODING => 'NONE', TTL => 'FOREVER', MIN_VERSIONS => '0', REPLICATION_SCOPE => '0', BLOOMFILTER => 'ROW', CACHE_INDEX_ON_WRITE => 'false', IN_MEMORY => 'false', CACHE_BLOOMS_ON_WRITE => 'false', PREFETCH_BLOCKS_ON_OPEN => 'false', COMPRESSION => 'NONE', BLOCKCACHE => 'true', BLOCKSIZE => '65536'} RootDir = file:/home/lixiang/standalonehbase/hbase/.tmp Table name == t1
2019-02-10 03:39:37,296 INFO  [RegionOpenAndInitThread-t1-1] regionserver.HRegion: Closed t1,,1549769977180.df77e6fff94073c0e3b99b22457e3d49.
2019-02-10 03:39:37,299 ERROR [RpcServer.default.FPBQ.Fifo.handler=29,queue=2,port=16000] master.TableStateManager: Unable to get table t1 state
org.apache.hadoop.hbase.master.TableStateManager$TableStateNotFoundException: t1
	at org.apache.hadoop.hbase.master.TableStateManager.getTableState(TableStateManager.java:215)
	at org.apache.hadoop.hbase.master.TableStateManager.isTableState(TableStateManager.java:147)
	at org.apache.hadoop.hbase.master.assignment.AssignmentManager.isTableDisabled(AssignmentManager.java:354)
	at org.apache.hadoop.hbase.rsgroup.RSGroupAdminServer.moveTables(RSGroupAdminServer.java:411)
	at org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint.assignTableToGroup(RSGroupAdminEndpoint.java:471)
	at org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint.postCreateTable(RSGroupAdminEndpoint.java:494)
	at org.apache.hadoop.hbase.master.MasterCoprocessorHost$13.call(MasterCoprocessorHost.java:350)
	at org.apache.hadoop.hbase.master.MasterCoprocessorHost$13.call(MasterCoprocessorHost.java:347)
	at org.apache.hadoop.hbase.coprocessor.CoprocessorHost$ObserverOperationWithoutResult.callObserver(CoprocessorHost.java:551)
	at org.apache.hadoop.hbase.coprocessor.CoprocessorHost.execOperation(CoprocessorHost.java:625)
	at org.apache.hadoop.hbase.master.MasterCoprocessorHost.postCreateTable(MasterCoprocessorHost.java:347)
	at org.apache.hadoop.hbase.master.HMaster$4.run(HMaster.java:2083)
	at org.apache.hadoop.hbase.master.procedure.MasterProcedureUtil.submitProcedure(MasterProcedureUtil.java:134)
	at org.apache.hadoop.hbase.master.HMaster.createTable(HMaster.java:2066)
	at org.apache.hadoop.hbase.master.MasterRpcServices.createTable(MasterRpcServices.java:644)
	at org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java)
	at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413)
	at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130)
	at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324)
	at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304)
2019-02-10 03:39:37,301 INFO  [PEWorker-12] hbase.MetaTableAccessor: Added 1 regions to meta.
2019-02-10 03:39:37,304 INFO  [PEWorker-12] hbase.MetaTableAccessor: Updated tableName=t1, state=ENABLING in hbase:meta
2019-02-10 03:39:37,305 INFO  [RpcServer.default.FPBQ.Fifo.handler=29,queue=2,port=16000] master.MasterRpcServices: Client=lixiang//10.23.10.9 procedure request for creating table: namespace: "default"
qualifier: "t1"
{code}
I will open a new JIRA to track that. 

> Do not move the table to null rsgroup when creating a existing table
> --------------------------------------------------------------------
>
>                 Key: HBASE-21866
>                 URL: https://issues.apache.org/jira/browse/HBASE-21866
>             Project: HBase
>          Issue Type: Bug
>          Components: rsgroup
>            Reporter: Xiang Li
>            Assignee: Xiang Li
>            Priority: Major
>         Attachments: HBASE-21866.master.000.patch
>
>
> By using the latest HBase master branch, the bug could be re-produced as:
>  # create 't1', 'cf1'
>  # create 't1', 'cf1'
> The following message is logged into HMaster's log:
> {code}
> INFO  [PEWorker-12] rsgroup.RSGroupAdminServer: Moving table t1 to RSGroup null
> {code}
> This is a wrong action that we should keep t1 as where it originally is.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)