You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/31 13:27:07 UTC
[GitHub] [arrow-datafusion] tustvold opened a new pull request, #2665: Remove ObjectStoreSchemaProvider (#2656)
tustvold opened a new pull request, #2665:
URL: https://github.com/apache/arrow-datafusion/pull/2665
# Which issue does this PR close?
Closes #2656
# Rationale for this change
This is not necessary, and is potentially very confusing as it ignores the runtime environment's object store registry in favor of its own.
# What changes are included in this PR?
Removes ObjectStoreSchemaProvider
# Are there any user-facing changes?
Yes, it removes ObjectStoreSchemaProvider
# Does this PR break compatibility with Ballista?
Probably not
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] tustvold merged pull request #2665: Remove ObjectStoreSchemaProvider (#2656)
Posted by GitBox <gi...@apache.org>.
tustvold merged PR #2665:
URL: https://github.com/apache/arrow-datafusion/pull/2665
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] tustvold commented on a diff in pull request #2665: Remove ObjectStoreSchemaProvider (#2656)
Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #2665:
URL: https://github.com/apache/arrow-datafusion/pull/2665#discussion_r885773427
##########
datafusion/core/src/catalog/schema.rs:
##########
@@ -163,7 +163,7 @@ mod tests {
#[tokio::test]
async fn test_schema_register_listing_table() {
let testdata = crate::test_util::parquet_test_data();
- let filename = format!("test:///{}/{}", testdata, "alltypes_plain.parquet");
+ let filename = format!("file:///{}/{}", testdata, "alltypes_plain.parquet");
Review Comment:
I originally used `test::///` however this doesn't work because of the special path handling necessary for file paths on Windows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] tustvold commented on a diff in pull request #2665: Remove ObjectStoreSchemaProvider (#2656)
Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #2665:
URL: https://github.com/apache/arrow-datafusion/pull/2665#discussion_r885638479
##########
datafusion/core/src/catalog/schema.rs:
##########
@@ -285,19 +165,23 @@ mod tests {
let filename = format!("{}/{}", testdata, "alltypes_plain.parquet");
let table_path = ListingTableUrl::parse(filename).unwrap();
- let schema = ObjectStoreSchemaProvider::new();
- let _store = schema.register_object_store("test", Arc::new(LocalFileSystem {}));
+ let catalog = MemoryCatalogProvider::new();
Review Comment:
Here we can see a MemoryCatalogProvider being used in place of ObjectStoreSchemaProvider
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org