You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Milamber ASF <mi...@apache.org> on 2013/03/06 00:03:24 UTC
Review Request: CLOUDSTACK-465 - French language file quotes are dropping
javascript syntax errors (after login)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9762/
-----------------------------------------------------------
Review request for cloudstack and Sebastien Goasguen.
Description
-------
Currently the 4.1 branch (and 4.0.1 too) doesn't works with the French version of UI.
See: https://issues.apache.org/jira/browse/CLOUDSTACK-465
With this patch, I download the current transifex resource file for French, and put in 4.1 branch, and accomplish this tasks:
* Replace all quote ' by \\'
* Fix some incompatibles chars in UTF-8
iconv: illegal input sequence at position 15910
iconv: illegal input sequence at position 17789
iconv: illegal input sequence at position 46774
iconv: illegal input sequence at position 72127
* changes charset from UTF-8 to ISO-8859-1 via iconv
iconv -f UTF-8 -t ISO-8859-1 messages_fr_FR.properties_UTF8 >messages_fr_FR.properties
* Transform ISO-8859-1 charset to ASCII with I18NEdit and re-order keys/values with alphabetical order
* Re-add Apache License v2
Please note, this patch leaves an issue with pre-completed field like in the login page, the value "Username" in field login shows "Nom d\'utilisateur"
After apply this patch, French version works on 4.1 branch
This addresses bug 465.
Diffs
-----
client/WEB-INF/classes/resources/messages_fr_FR.properties e29d61b
Diff: https://reviews.apache.org/r/9762/diff/
Testing
-------
Thanks,
Milamber ASF
Re: Review Request: CLOUDSTACK-465 - French language file quotes are
dropping javascript syntax errors (after login)
Posted by Sebastien Goasguen <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9762/#review17473
-----------------------------------------------------------
Ship it!
Tested on 4.1. Committed to master:
38aec6fc4d490f9aecaf9dd56116f45cd1eb60ed
committed to 4.1:
5807635533261adbb8fad98201caf5c2b7ba5df7
Can you close the review as submitted.
Thanks for the patch, if you feel like helping with the japanese/russian/chinese UI as well, please do :)
- Sebastien Goasguen
On March 5, 2013, 11:03 p.m., Milamber ASF wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9762/
> -----------------------------------------------------------
>
> (Updated March 5, 2013, 11:03 p.m.)
>
>
> Review request for cloudstack and Sebastien Goasguen.
>
>
> Description
> -------
>
> Currently the 4.1 branch (and 4.0.1 too) doesn't works with the French version of UI.
> See: https://issues.apache.org/jira/browse/CLOUDSTACK-465
>
> With this patch, I download the current transifex resource file for French, and put in 4.1 branch, and accomplish this tasks:
>
> * Replace all quote ' by \\'
>
> * Fix some incompatibles chars in UTF-8
> iconv: illegal input sequence at position 15910
> iconv: illegal input sequence at position 17789
> iconv: illegal input sequence at position 46774
> iconv: illegal input sequence at position 72127
>
> * changes charset from UTF-8 to ISO-8859-1 via iconv
> iconv -f UTF-8 -t ISO-8859-1 messages_fr_FR.properties_UTF8 >messages_fr_FR.properties
>
> * Transform ISO-8859-1 charset to ASCII with I18NEdit and re-order keys/values with alphabetical order
>
> * Re-add Apache License v2
>
>
> Please note, this patch leaves an issue with pre-completed field like in the login page, the value "Username" in field login shows "Nom d\'utilisateur"
>
>
> After apply this patch, French version works on 4.1 branch
>
>
> This addresses bug 465.
>
>
> Diffs
> -----
>
> client/WEB-INF/classes/resources/messages_fr_FR.properties e29d61b
>
> Diff: https://reviews.apache.org/r/9762/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Milamber ASF
>
>