You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/02/08 15:00:22 UTC
[GitHub] [incubator-apisix] agile6v opened a new pull request #1113:
Feature: Add support for PROXY Protocol.
agile6v opened a new pull request #1113: Feature: Add support for PROXY Protocol.
URL: https://github.com/apache/incubator-apisix/pull/1113
### Summary
1. Support Proxy Protocol
2. Add X-Forwarded-* headers to upstream
- X-Forwarded-For
- X-Forwarded-Proto
- X-Forwarded-Host
- X-Forwarded-Port
### Issues resolved
Fix #1106
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] moonming merged pull request #1113: Feature: Add
support for PROXY Protocol.
Posted by GitBox <gi...@apache.org>.
moonming merged pull request #1113: Feature: Add support for PROXY Protocol.
URL: https://github.com/apache/incubator-apisix/pull/1113
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] agile6v commented on a change in pull request
#1113: Feature: Add support for PROXY Protocol.
Posted by GitBox <gi...@apache.org>.
agile6v commented on a change in pull request #1113: Feature: Add support for PROXY Protocol.
URL: https://github.com/apache/incubator-apisix/pull/1113#discussion_r377062458
##########
File path: bin/apisix
##########
@@ -200,10 +204,14 @@ http {
include mime.types;
- real_ip_header {* real_ip_header *};
- {% for _, real_ip in ipairs(real_ip_from) do %}
+ {% if http.real_ip_header then %}
Review comment:
Yes. I will add it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] moonming commented on a change in pull request
#1113: Feature: Add support for PROXY Protocol.
Posted by GitBox <gi...@apache.org>.
moonming commented on a change in pull request #1113: Feature: Add support for PROXY Protocol.
URL: https://github.com/apache/incubator-apisix/pull/1113#discussion_r376768509
##########
File path: bin/apisix
##########
@@ -200,10 +204,14 @@ http {
include mime.types;
- real_ip_header {* real_ip_header *};
- {% for _, real_ip in ipairs(real_ip_from) do %}
+ {% if http.real_ip_header then %}
Review comment:
Is this a modification that is not backward compatible?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services