You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tvm.apache.org by Lunderberg <no...@github.com.INVALID> on 2021/10/06 14:05:49 UTC
[apache/tvm-rfcs] [RFC][TIR] 1-d AllocateNode::extent (#40)
This RFC changes `Array<PrimExpr> AllocateNode::extents` to `PrimExpr AllocateNode::extent`, giving the 1-d size of the buffer to be allocated. This is part of the separation between logical layout and physical layout, proposed in [RFC#0039](https://github.com/apache/tvm-rfcs/pull/0039).
TODO: Rendered markdown link
You can view, comment on, or merge this pull request online at:
https://github.com/apache/tvm-rfcs/pull/40
-- Commit Summary --
* <a href="https://github.com/apache/tvm-rfcs/pull/40/commits/06c8dea05cc1eb154e6799656650b333b2b97771">[RFC][TIR] 1-d AllocateNode::extent</a>
-- File Changes --
A rfcs/XXXX-allocate-node-1d-extent.md (111)
-- Patch Links --
https://github.com/apache/tvm-rfcs/pull/40.patch
https://github.com/apache/tvm-rfcs/pull/40.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm-rfcs/pull/40
Re: [apache/tvm-rfcs] [RFC][TIR] Change AllocateNode::extent to 1-D
(#40)
Posted by Wuwei Lin <no...@github.com.INVALID>.
Thanks for the RFC. A quick question: RFC #39 mentioned the usage of `PHYSICAL_AXIS_SEPARATOR` to support n-d physical allocation (if supported by runtime), how will it work with 1-d extent here?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm-rfcs/pull/40#issuecomment-938810981
Re: [apache/tvm-rfcs] [RFC][TIR] Change AllocateNode::extent to 1-D
(#40)
Posted by Lunderberg <no...@github.com.INVALID>.
Closed #40.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm-rfcs/pull/40#event-5536746113
Re: [apache/tvm-rfcs] [RFC][TIR] Change AllocateNode::extent to 1-D
(#40)
Posted by Lunderberg <no...@github.com.INVALID>.
Closing this RFC, as it is no longer applicable after significant changes made to #39.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm-rfcs/pull/40#issuecomment-954215697
Re: [apache/tvm-rfcs] [RFC][TIR] Change AllocateNode::extent to 1-D
(#40)
Posted by Lunderberg <no...@github.com.INVALID>.
This is the first in a series of proposed changes, and this one on its own won't be able to support the `PHYSICAL_AXIS_SEPARATOR`. In the [Impacted TIR Nodes](https://github.com/Lunderberg/tvm-rfcs/blob/data_layout/rfcs/0039-buffer-physical-layout.md#impacted-tir-nodes) section of RFC #39, under `AllocateNode`, it gives a description of the changes being made. This first change removes all information of the logical shape from the `AllocateNode`, and the follow-up change will then extend to allow for N-d physical shapes.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm-rfcs/pull/40#issuecomment-939073862