You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cloudstack.apache.org by Chris Suich <ch...@netapp.com> on 2013/10/07 14:43:58 UTC

Review Request 14516: Added storage_provider_name to storage_pool_view

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14516/
-----------------------------------------------------------

Review request for cloudstack.


Repository: cloudstack-git


Description
-------

I added the 'storage_provider_name' field to the 'storage_pool_view' just as 'image_provider_name' is in 'image_store_view'.

This is my first time making a DB change, so please let me know if I did not properly update the db upgrade script.


Diffs
-----

  server/src/com/cloud/api/query/vo/StoragePoolJoinVO.java 69f2204 
  setup/db/db/schema-420to430.sql 653ff77 

Diff: https://reviews.apache.org/r/14516/diff/


Testing
-------


Thanks,

Chris Suich

Re: Review Request 14516: Added storage_provider_name to storage_pool_view

Posted by edison su <ed...@citrix.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14516/#review26743
-----------------------------------------------------------

Ship it!


Ship It!

- edison su


On Oct. 7, 2013, 12:43 p.m., Chris Suich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14516/
> -----------------------------------------------------------
> 
> (Updated Oct. 7, 2013, 12:43 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> I added the 'storage_provider_name' field to the 'storage_pool_view' just as 'image_provider_name' is in 'image_store_view'.
> 
> This is my first time making a DB change, so please let me know if I did not properly update the db upgrade script.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/api/query/vo/StoragePoolJoinVO.java 69f2204 
>   setup/db/db/schema-420to430.sql 653ff77 
> 
> Diff: https://reviews.apache.org/r/14516/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Chris Suich
> 
>