You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/12/16 18:10:52 UTC
[GitHub] [kafka] JoeCqupt opened a new pull request #11607: KAFKA-13544: fix FinalizedFeatureChangeListener deadlock
JoeCqupt opened a new pull request #11607:
URL: https://github.com/apache/kafka/pull/11607
KAFKA-13544
because shutdown hook case deadlock.
### Committer Checklist (excluded from commit message)
- [x] Verify design and implementation
- [x] Verify test coverage and CI build status
- [x] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] JoeCqupt commented on pull request #11607: KAFKA-13544: fix FinalizedFeatureChangeListener deadlock
Posted by GitBox <gi...@apache.org>.
JoeCqupt commented on pull request #11607:
URL: https://github.com/apache/kafka/pull/11607#issuecomment-996063587
call for review @junrao @showuon @dajac @guozhangwang @ijuma
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] JoeCqupt commented on pull request #11607: KAFKA-13544: fix FinalizedFeatureChangeListener deadlock
Posted by GitBox <gi...@apache.org>.
JoeCqupt commented on pull request #11607:
URL: https://github.com/apache/kafka/pull/11607#issuecomment-996061715
ChangeNotificationProcessorThread extends ShutdownableThread, so when ` thread.shutdown()` retrun it means that this thread has shutdownCompleted, it is unnecessary to call `thread.join()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] junrao merged pull request #11607: KAFKA-13544: fix FinalizedFeatureChangeListener deadlock
Posted by GitBox <gi...@apache.org>.
junrao merged pull request #11607:
URL: https://github.com/apache/kafka/pull/11607
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] JoeCqupt edited a comment on pull request #11607: KAFKA-13544: fix FinalizedFeatureChangeListener deadlock
Posted by GitBox <gi...@apache.org>.
JoeCqupt edited a comment on pull request #11607:
URL: https://github.com/apache/kafka/pull/11607#issuecomment-996061715
ChangeNotificationProcessorThread extends ShutdownableThread, so when ` thread.shutdown()` return it means that this thread has shutdownCompleted, it is unnecessary to call `thread.join()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dajac commented on pull request #11607: KAFKA-13544: fix FinalizedFeatureChangeListener deadlock
Posted by GitBox <gi...@apache.org>.
dajac commented on pull request #11607:
URL: https://github.com/apache/kafka/pull/11607#issuecomment-1000506562
@junrao Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] junrao commented on pull request #11607: KAFKA-13544: fix FinalizedFeatureChangeListener deadlock
Posted by GitBox <gi...@apache.org>.
junrao commented on pull request #11607:
URL: https://github.com/apache/kafka/pull/11607#issuecomment-999825371
@dajac : Since this is a really small fix for a potential deadlock, I merged it to 3.1 branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org