[GitHub] [james-project] chibenwa commented on a change in pull request #910: JAMES-3715 Add TCP transport level tests for IMAP IDLE

[GitBox <gi...@apache.org>]

chibenwa commented on a change in pull request #910:
URL: https://github.com/apache/james-project/pull/910#discussion_r822450023



##########
File path: server/protocols/protocols-imap4/src/test/java/org/apache/james/imapserver/netty/IMAPServerTest.java
##########
@@ -970,4 +977,106 @@ void searchingASingleUTF8CriterionShouldComplete() throws Exception {
             store.close();
         }
     }
+
+    @Nested
+    class Idle {
+        IMAPServer imapServer;
+        private int port;
+        private MailboxSession mailboxSession;
+        private MessageManager inbox;
+
+        @BeforeEach
+        void beforeEach() throws Exception {
+            imapServer = createImapServer("imapServer.xml");
+            port = imapServer.getListenAddresses().get(0).getPort();
+            mailboxSession = memoryIntegrationResources.getMailboxManager().createSystemSession(USER);
+            memoryIntegrationResources.getMailboxManager()
+                .createMailbox(MailboxPath.inbox(USER), mailboxSession);
+            inbox = memoryIntegrationResources.getMailboxManager().getMailbox(MailboxPath.inbox(USER), mailboxSession);
+        }
+
+        @AfterEach
+        void tearDown() {
+            imapServer.destroy();
+        }
+
+        @Test
+        void idleShouldSendInitialContinuation() throws Exception {
+            SocketChannel server = SocketChannel.open();

Review comment:
       > This is more like a client than a server?
   
   Yes we are opening a TCP client connection to test the server.
   
   > BTW should we put this SocketChannel.open() into BeforeEach and close it in AfterEach?
   
   :+1: 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org