You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/10/25 01:52:33 UTC
[GitHub] [hudi] danny0405 commented on a diff in pull request #7053: [HUDI-5087]Fix incorrect maxValue getting from metatable
danny0405 commented on code in PR #7053:
URL: https://github.com/apache/hudi/pull/7053#discussion_r1003920600
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieMetadataPayload.java:
##########
@@ -639,8 +639,8 @@ private static HoodieMetadataColumnStats mergeColumnStatsRecords(HoodieMetadataC
Comparable maxValue =
(Comparable) Stream.of(
- (Comparable) unwrapStatisticValueWrapper(prevColumnStats.getMinValue()),
- (Comparable) unwrapStatisticValueWrapper(newColumnStats.getMinValue()))
+ (Comparable) unwrapStatisticValueWrapper(prevColumnStats.getMaxValue()),
+ (Comparable) unwrapStatisticValueWrapper(newColumnStats.getMaxValue()))
Review Comment:
Nice catch, is there any possibility we write a unit test for this clazz ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org