[GitHub] [apisix-dashboard] liuyang211 edited a comment on pull request #1477: feat: support etcd prefix as apisix does

[GitBox <gi...@apache.org>]

liuyang211 edited a comment on pull request #1477:
URL: https://github.com/apache/apisix-dashboard/pull/1477#issuecomment-782577827


   > @liuyang211 need some test cases. please refer to https://github.com/apache/apisix-dashboard/blob/master/api/test/shell/cli_test.sh#L300-L327
   > thanks.
   
   I run these cmds to test it locally, 
   ```shell
   cd apisix-dashboard/api
   ./test/shell/cli_test.sh
   ```
   but fail at
   `
   ./test/shell/cli_test.sh: line 347: ./etcd-v3.4.14-linux-amd64/etcd: No such file or directory
   `
   
   Do I miss something?
   
   BTW
   1. /tmp/manager-api is used as both directory and file.
   https://github.com/apache/apisix-dashboard/blob/master/api/test/shell/cli_test.sh#L143-L144
   https://github.com/apache/apisix-dashboard/blob/master/api/test/shell/cli_test.sh#L166
   This seems to raise this error if `rm /tmp/manager-api` is not manually excuted before next test.
   `cp: cannot overwrite non-directory '/tmp/manager-api' with directory '/home/newbie/dev/apisix-dashboard/api'`
   
   2. These two lines should swap to avoid error message when stopping manager-api
   https://github.com/apache/apisix-dashboard/blob/master/api/test/shell/cli_test.sh#L385-L387


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org