You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brpc.apache.org by "Sea-n (via GitHub)" <gi...@apache.org> on 2023/10/07 13:47:05 UTC
[PR] Update logo in readme (brpc)
Sea-n opened a new pull request, #2402:
URL: https://github.com/apache/brpc/pull/2402
> (template text deleted)
Original Logo in README:
It might be better if we adjust for dark mode.
New logo:
| Light Mode | Dark Mode |
| :--: | :--: |
|  |  |
Logo source is modified from https://brpc.apache.org/:
Not sure should we keep the "Apache" here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [PR] Update logo in readme (brpc)
Posted by "Sea-n (via GitHub)" <gi...@apache.org>.
Sea-n commented on PR #2402:
URL: https://github.com/apache/brpc/pull/2402#issuecomment-1775323285
Oh, I get confused at that time. 😖
How about now? changed the dark mode image to `logo-white.png` and keep the black one (light mode) as `logo.png`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [PR] Update logo in readme (brpc)
Posted by "wwbmmm (via GitHub)" <gi...@apache.org>.
wwbmmm merged PR #2402:
URL: https://github.com/apache/brpc/pull/2402
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [PR] Update logo in readme (brpc)
Posted by "serverglen (via GitHub)" <gi...@apache.org>.
serverglen commented on PR #2402:
URL: https://github.com/apache/brpc/pull/2402#issuecomment-1755224616
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [PR] Update logo in readme (brpc)
Posted by "wwbmmm (via GitHub)" <gi...@apache.org>.
wwbmmm commented on PR #2402:
URL: https://github.com/apache/brpc/pull/2402#issuecomment-1760669303
It's better to keep the original `logo.png` as dark mode and `logo-light.png` as light mode
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org