You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Eugene Chekanskiy <ec...@hortonworks.com> on 2014/03/07 17:19:46 UTC

Review Request 18906: falcon-env.sh needs to be templatized and JAVA_HOME needs to be set to the java home being used for other services

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18906/
-----------------------------------------------------------

Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-4997
    https://issues.apache.org/jira/browse/AMBARI-4997


Repository: ambari


Description
-------

java_home setting dynamically now.


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/2.1.1/services/FALCON/configuration/global.xml 7734ac2 
  ambari-server/src/main/resources/stacks/HDP/2.1.1/services/FALCON/package/scripts/falcon.py 58d3af7 
  ambari-server/src/main/resources/stacks/HDP/2.1.1/services/FALCON/package/scripts/params.py 77e4cca 
  ambari-server/src/main/resources/stacks/HDP/2.1.1/services/FALCON/package/templates/falcon-env.sh.j2 PRE-CREATION 
  ambari-server/src/test/python/stacks/2.0.6/configs/default.hbasedecom.json 92d6658 
  ambari-server/src/test/python/stacks/2.0.6/configs/default.json 2e40078 
  ambari-server/src/test/python/stacks/2.0.6/configs/secured.json a7e3896 
  ambari-server/src/test/python/stacks/2.1.1/FALCON/test_falcon_client.py 9e22bc0 
  ambari-server/src/test/python/stacks/2.1.1/FALCON/test_falcon_server.py 6e48c35 
  ambari-server/src/test/python/stacks/2.1.1/configs/default.json a2dacde 
  ambari-server/src/test/python/stacks/2.1.1/configs/secured.json 4c3a480 
  ambari-server/src/test/python/stacks/2.1.1/configs/secured.json.orig a86c825 

Diff: https://reviews.apache.org/r/18906/diff/


Testing
-------

----------------------------------------------------------------------
Total run:503
Total errors:0
Total failures:0
OK


Thanks,

Eugene Chekanskiy


Re: Review Request 18906: falcon-env.sh needs to be templatized and JAVA_HOME needs to be set to the java home being used for other services

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18906/#review36542
-----------------------------------------------------------

Ship it!


Ship It!

- Dmitro Lisnichenko


On March 7, 2014, 5:30 p.m., Eugene Chekanskiy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18906/
> -----------------------------------------------------------
> 
> (Updated March 7, 2014, 5:30 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-4997
>     https://issues.apache.org/jira/browse/AMBARI-4997
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> java_home setting dynamically now.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.1.1/services/FALCON/configuration/global.xml 7734ac2 
>   ambari-server/src/main/resources/stacks/HDP/2.1.1/services/FALCON/package/scripts/falcon.py 58d3af7 
>   ambari-server/src/main/resources/stacks/HDP/2.1.1/services/FALCON/package/scripts/params.py 77e4cca 
>   ambari-server/src/main/resources/stacks/HDP/2.1.1/services/FALCON/package/templates/falcon-env.sh.j2 PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.hbasedecom.json 92d6658 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json 2e40078 
>   ambari-server/src/test/python/stacks/2.0.6/configs/secured.json a7e3896 
>   ambari-server/src/test/python/stacks/2.1.1/FALCON/test_falcon_client.py 9e22bc0 
>   ambari-server/src/test/python/stacks/2.1.1/FALCON/test_falcon_server.py 6e48c35 
>   ambari-server/src/test/python/stacks/2.1.1/configs/default.json a2dacde 
>   ambari-server/src/test/python/stacks/2.1.1/configs/secured.json 4c3a480 
>   ambari-server/src/test/python/stacks/2.1.1/configs/secured.json.orig a86c825 
> 
> Diff: https://reviews.apache.org/r/18906/diff/
> 
> 
> Testing
> -------
> 
> ----------------------------------------------------------------------
> Total run:503
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>


Re: Review Request 18906: falcon-env.sh needs to be templatized and JAVA_HOME needs to be set to the java home being used for other services

Posted by Eugene Chekanskiy <ec...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18906/
-----------------------------------------------------------

(Updated March 7, 2014, 5:30 p.m.)


Review request for Ambari and Dmitro Lisnichenko.


Changes
-------

deleted ambari-server/src/test/python/stacks/2.1.1/configs/secured.json.orig


Bugs: AMBARI-4997
    https://issues.apache.org/jira/browse/AMBARI-4997


Repository: ambari


Description
-------

java_home setting dynamically now.


Diffs (updated)
-----

  ambari-server/src/main/resources/stacks/HDP/2.1.1/services/FALCON/configuration/global.xml 7734ac2 
  ambari-server/src/main/resources/stacks/HDP/2.1.1/services/FALCON/package/scripts/falcon.py 58d3af7 
  ambari-server/src/main/resources/stacks/HDP/2.1.1/services/FALCON/package/scripts/params.py 77e4cca 
  ambari-server/src/main/resources/stacks/HDP/2.1.1/services/FALCON/package/templates/falcon-env.sh.j2 PRE-CREATION 
  ambari-server/src/test/python/stacks/2.0.6/configs/default.hbasedecom.json 92d6658 
  ambari-server/src/test/python/stacks/2.0.6/configs/default.json 2e40078 
  ambari-server/src/test/python/stacks/2.0.6/configs/secured.json a7e3896 
  ambari-server/src/test/python/stacks/2.1.1/FALCON/test_falcon_client.py 9e22bc0 
  ambari-server/src/test/python/stacks/2.1.1/FALCON/test_falcon_server.py 6e48c35 
  ambari-server/src/test/python/stacks/2.1.1/configs/default.json a2dacde 
  ambari-server/src/test/python/stacks/2.1.1/configs/secured.json 4c3a480 
  ambari-server/src/test/python/stacks/2.1.1/configs/secured.json.orig a86c825 

Diff: https://reviews.apache.org/r/18906/diff/


Testing
-------

----------------------------------------------------------------------
Total run:503
Total errors:0
Total failures:0
OK


Thanks,

Eugene Chekanskiy


Re: Review Request 18906: falcon-env.sh needs to be templatized and JAVA_HOME needs to be set to the java home being used for other services

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18906/#review36528
-----------------------------------------------------------

Ship it!


Ship It!

- Dmitro Lisnichenko


On March 7, 2014, 4:19 p.m., Eugene Chekanskiy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18906/
> -----------------------------------------------------------
> 
> (Updated March 7, 2014, 4:19 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-4997
>     https://issues.apache.org/jira/browse/AMBARI-4997
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> java_home setting dynamically now.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.1.1/services/FALCON/configuration/global.xml 7734ac2 
>   ambari-server/src/main/resources/stacks/HDP/2.1.1/services/FALCON/package/scripts/falcon.py 58d3af7 
>   ambari-server/src/main/resources/stacks/HDP/2.1.1/services/FALCON/package/scripts/params.py 77e4cca 
>   ambari-server/src/main/resources/stacks/HDP/2.1.1/services/FALCON/package/templates/falcon-env.sh.j2 PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.hbasedecom.json 92d6658 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json 2e40078 
>   ambari-server/src/test/python/stacks/2.0.6/configs/secured.json a7e3896 
>   ambari-server/src/test/python/stacks/2.1.1/FALCON/test_falcon_client.py 9e22bc0 
>   ambari-server/src/test/python/stacks/2.1.1/FALCON/test_falcon_server.py 6e48c35 
>   ambari-server/src/test/python/stacks/2.1.1/configs/default.json a2dacde 
>   ambari-server/src/test/python/stacks/2.1.1/configs/secured.json 4c3a480 
>   ambari-server/src/test/python/stacks/2.1.1/configs/secured.json.orig a86c825 
> 
> Diff: https://reviews.apache.org/r/18906/diff/
> 
> 
> Testing
> -------
> 
> ----------------------------------------------------------------------
> Total run:503
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>