You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/08/17 09:14:02 UTC
[GitHub] [incubator-doris] EmmyMiao87 opened a new pull request #4375: Fix errors when alter materialized view which based on dup table
EmmyMiao87 opened a new pull request #4375:
URL: https://github.com/apache/incubator-doris/pull/4375
## Proposed changes
1. Input the correct keys type when mv is updated.
The keys type of mv should be used in schema change job rather then keys type of base table.
Otherwise, the be will core and thrown exception "Create replicas failed".
2. Forbidden add non-key column on agg mv directly when base table is duplicate model
If a dup table has a agg mv, user will not add a non-key column on mv.
The non-key column can only be added to dup index.
Fixed #4374
Change-Id: I375f695b3109e513622110cf0ca04a4034780909
## Types of changes
What types of changes does your code introduce to Doris?
_Put an `x` in the boxes that apply_
- [x] Bugfix (non-breaking change which fixes an issue)
- [] New feature (non-breaking change which adds functionality)
- [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [] Documentation Update (if none of the other choices apply)
- [] Code refactor (Modify the code structure, format the code, etc...)
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [x] I have create an issue on (Fix #ISSUE), and have described the bug/feature there in detail
- [x] Compiling and unit tests pass locally with my changes
- [x] I have added tests that prove my fix is effective or that my feature works
- [] If this change need a document change, I have updated the document
- [] Any dependent changes have been merged
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #4375: Fix errors when alter materialized view which based on dup table
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #4375:
URL: https://github.com/apache/incubator-doris/pull/4375#discussion_r471542377
##########
File path: fe/fe-core/src/main/java/org/apache/doris/catalog/OlapTable.java
##########
@@ -556,7 +556,9 @@ public KeysType getKeysType() {
}
public KeysType getKeysTypeByIndexId(long indexId) {
- return indexIdToMeta.get(indexId).getKeysType();
+ MaterializedIndexMeta indexMeta = indexIdToMeta.get(indexId);
+ Preconditions.checkNotNull(indexMeta);
Review comment:
You can add some message if you want to check it.
```suggestion
Preconditions.checkNotNull(indexMeta, "index id: " + indexId);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] wutiangan commented on a change in pull request #4375: Fix errors when alter materialized view which based on dup table
Posted by GitBox <gi...@apache.org>.
wutiangan commented on a change in pull request #4375:
URL: https://github.com/apache/incubator-doris/pull/4375#discussion_r471537858
##########
File path: fe/fe-core/src/main/java/org/apache/doris/alter/SchemaChangeJobV2.java
##########
@@ -237,7 +238,9 @@ protected void runPendingJob() throws AlterCancelException {
short shadowShortKeyColumnCount = indexShortKeyMap.get(shadowIdxId);
List<Column> shadowSchema = indexSchemaMap.get(shadowIdxId);
int shadowSchemaHash = indexSchemaVersionAndHashMap.get(shadowIdxId).schemaHash;
- int originSchemaHash = tbl.getSchemaHashByIndexId(indexIdMap.get(shadowIdxId));
+ long originIndexId = indexIdMap.get(shadowIdxId);
+ int originSchemaHash = tbl.getSchemaHashByIndexId(originIndexId);
Review comment:
can this variable be remove?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #4375: Fix errors when alter materialized view which based on dup table
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #4375:
URL: https://github.com/apache/incubator-doris/pull/4375
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] wutiangan commented on a change in pull request #4375: Fix errors when alter materialized view which based on dup table
Posted by GitBox <gi...@apache.org>.
wutiangan commented on a change in pull request #4375:
URL: https://github.com/apache/incubator-doris/pull/4375#discussion_r471537748
##########
File path: fe/fe-core/src/main/java/org/apache/doris/alter/SchemaChangeHandler.java
##########
@@ -556,6 +556,10 @@ private void addColumnInternal(OlapTable olapTable, Column newColumn, ColumnPosi
throw new DdlException("Can not assign aggregation method on column in Duplicate data model table: " + newColName);
}
if (!newColumn.isKey()) {
Review comment:
why not put "from lint 559 to line 562" outside of if stmt?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #4375: Fix errors when alter materialized view which based on dup table
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 commented on a change in pull request #4375:
URL: https://github.com/apache/incubator-doris/pull/4375#discussion_r472626637
##########
File path: fe/fe-core/src/main/java/org/apache/doris/alter/SchemaChangeHandler.java
##########
@@ -556,6 +556,10 @@ private void addColumnInternal(OlapTable olapTable, Column newColumn, ColumnPosi
throw new DdlException("Can not assign aggregation method on column in Duplicate data model table: " + newColName);
}
if (!newColumn.isKey()) {
Review comment:
I didn't understand what you mean...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org