[GitHub] pnowojski commented on a change in pull request #6736: [FLINK-10398][table] Add Tanh math function supported in Table API and SQL

[GitBox <gi...@apache.org>]

pnowojski commented on a change in pull request #6736: [FLINK-10398][table] Add Tanh math function supported in Table API and SQL
URL: https://github.com/apache/flink/pull/6736#discussion_r225080465
 
 

 ##########
 File path: docs/dev/table/functions.md
 ##########
 @@ -1219,6 +1219,18 @@ TAN(numeric)
       </td>
     </tr>
 
+    <tr>
+      <td>
+        {% highlight text %}
+TANH(numeric)
+{% endhighlight %}
+      </td>
+      <td>
+        <p>Returns the hyperbolic tangent of <i>NUMERIC</i>.</p> 
+        <p>Return value type is <i>DOUBLE</i>.</p>
 
 Review comment:
   In my review I didn't focus as much on the style of the documentation, since I'm not familiar with it myself, especially once @xccui jumped in to this part I wanted to refer to his judgement there. Somehow this issue must have slipped our (mine and @xccui) attention that at the end it wasn't properly addressed in the `cosh` PR. Before merging I had an impression that @xccui comments were fully addressed, sorry if that wasn't the case.
   
   btw, @yanghua I think you skipped two occurrences of `<i>NUMERIC</i>`. Here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services