You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/06/22 02:55:01 UTC
[jira] [Commented] (SAMZA-1340) StreamProcessor does not propagate
container failures from StreamTask
[ https://issues.apache.org/jira/browse/SAMZA-1340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16058643#comment-16058643 ]
ASF GitHub Bot commented on SAMZA-1340:
---------------------------------------
GitHub user navina opened a pull request:
https://github.com/apache/samza/pull/230
SAMZA-1340 - StreamProcessor does not propagate container failures from StreamTask
Storing the exception seen from the container in the `SamzaContainerListener#onFailure(Throwable)` in the StreamProcessor.
`JobCoordinator#stop` callback inspects this stored exception and invokes the correct callback for StreamProcessorLifecycleListener.
It is pretty difficult to add all test cases. Suggestion welcome for improving code/testing.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/navina/samza LISAMZA-5272
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/samza/pull/230.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #230
----
commit 839473cf0dea43ba565154c5377b138655db8a5d
Author: Navina Ramesh <na...@apache.org>
Date: 2017-06-19T22:49:00Z
Adding a streamprocessor test to verify containerexception is getting persisted in processor
commit 5475f6a301a37d9e2ede1d2a8e1e319cdc812fcc
Author: Navina Ramesh <na...@apache.org>
Date: 2017-06-20T01:16:27Z
Removing unused listener in StreamProcessorTestUtils
commit 213bb2e8afff6f6421cff0697b9b5700ba5c70a1
Author: Navina Ramesh <na...@apache.org>
Date: 2017-06-22T02:28:13Z
Fixing checkstyle
----
> StreamProcessor does not propagate container failures from StreamTask
> ---------------------------------------------------------------------
>
> Key: SAMZA-1340
> URL: https://issues.apache.org/jira/browse/SAMZA-1340
> Project: Samza
> Issue Type: Bug
> Affects Versions: 0.131
> Reporter: Navina Ramesh
> Assignee: Navina Ramesh
> Fix For: 0.13.1
>
>
> Based on [~cpettitt]'s observation:
> bq. I'm on Samza's master branch. If my task throws from one of its operators I get back a success state from the LocalApplicationRunner.
> bq. The root cause appears to be in SamzaContainerListener#onContainerFailed in StreamProcessor. There we call a regular stop and have not recorded anywhere that an exception was raised. Consequently onCoordinatorStop is invoked and the processorListener gets its onShutdown callback called instead of onFailure via onCoordinatorFailure.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)