You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Sandeep Tata (JIRA)" <ji...@apache.org> on 2009/08/19 02:12:14 UTC
[jira] Created: (CASSANDRA-375) Echo writes to bootstrapping nodes
Echo writes to bootstrapping nodes
----------------------------------
Key: CASSANDRA-375
URL: https://issues.apache.org/jira/browse/CASSANDRA-375
Project: Cassandra
Issue Type: Improvement
Components: Core
Environment: All
Reporter: Sandeep Tata
Assignee: Sandeep Tata
Fix For: 0.5
Writes that arrive during bootstrap need to be sent to the r replicas as well as the new node being bootstrapped. In the current code, only the existing replicas get the writes that arrive during bootstrap.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-375) Echo writes to bootstrapping nodes
Posted by "Sandeep Tata (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sandeep Tata updated CASSANDRA-375:
-----------------------------------
Attachment: 375.patch
Here's what the patch does:
1. Switch bootstrapNodes in TokenMetadata to Map<Token,EndPoint> so RackUnawareStrategy can use it.
2. Fix AbstractStrategy and RackUnawareStrategy to incorporate the bootstrapping nodes for getHintedStorageEndPoints through StorageService.getNStorageEndPointMap (now used by insert and insertBlocking after 383)
3. Add unit test fot RackUnawareStrategy to test if bootstrapping nodes are being returned correctly.
> Echo writes to bootstrapping nodes
> ----------------------------------
>
> Key: CASSANDRA-375
> URL: https://issues.apache.org/jira/browse/CASSANDRA-375
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Environment: All
> Reporter: Sandeep Tata
> Assignee: Sandeep Tata
> Fix For: 0.5
>
> Attachments: 375.patch
>
>
> Writes that arrive during bootstrap need to be sent to the r replicas as well as the new node being bootstrapped. In the current code, only the existing replicas get the writes that arrive during bootstrap.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-375) Echo writes to bootstrapping nodes
Posted by "Sandeep Tata (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sandeep Tata updated CASSANDRA-375:
-----------------------------------
Attachment: 375-v2.patch
Rebased.
> Echo writes to bootstrapping nodes
> ----------------------------------
>
> Key: CASSANDRA-375
> URL: https://issues.apache.org/jira/browse/CASSANDRA-375
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Environment: All
> Reporter: Sandeep Tata
> Assignee: Sandeep Tata
> Fix For: 0.5
>
> Attachments: 375-v2.patch, 375.patch
>
>
> Writes that arrive during bootstrap need to be sent to the r replicas as well as the new node being bootstrapped. In the current code, only the existing replicas get the writes that arrive during bootstrap.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-375) Echo writes to bootstrapping
nodes
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747979#action_12747979 ]
Jonathan Ellis commented on CASSANDRA-375:
------------------------------------------
Why do we sometimes want to pass null in for the bootstrap map?
List<Token> tokenList = getStorageTokens(token, tokenToEndPointMap, null);
> Echo writes to bootstrapping nodes
> ----------------------------------
>
> Key: CASSANDRA-375
> URL: https://issues.apache.org/jira/browse/CASSANDRA-375
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Environment: All
> Reporter: Sandeep Tata
> Assignee: Sandeep Tata
> Fix For: 0.5
>
> Attachments: 375-v2.patch, 375.patch
>
>
> Writes that arrive during bootstrap need to be sent to the r replicas as well as the new node being bootstrapped. In the current code, only the existing replicas get the writes that arrive during bootstrap.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-375) Echo writes to bootstrapping
nodes
Posted by "Sandeep Tata (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12748036#action_12748036 ]
Sandeep Tata commented on CASSANDRA-375:
----------------------------------------
We do this when we're trying to get the endPoints for a read (regular getStorageEndPoints instead of getStorageEndPointsForWrite). We don't want to involve any of the bootstrap nodes for reads -- so we simply pass in a null. (The tokenToEndPointMap won't contain any bootstrap nodes anyway).
> Echo writes to bootstrapping nodes
> ----------------------------------
>
> Key: CASSANDRA-375
> URL: https://issues.apache.org/jira/browse/CASSANDRA-375
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Environment: All
> Reporter: Sandeep Tata
> Assignee: Sandeep Tata
> Fix For: 0.5
>
> Attachments: 375-v2.patch, 375.patch
>
>
> Writes that arrive during bootstrap need to be sent to the r replicas as well as the new node being bootstrapped. In the current code, only the existing replicas get the writes that arrive during bootstrap.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-375) Echo writes to bootstrapping
nodes
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12748356#action_12748356 ]
Hudson commented on CASSANDRA-375:
----------------------------------
Integrated in Cassandra #179 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/179/])
1. Switch bootstrapNodes in TokenMetadata to Map<Token,EndPoint> so RackUnawareStrategy can use it.
2. Fix AbstractStrategy and RackUnawareStrategy to incorporate the bootstrapping nodes for
getHintedStorageEndPoints through StorageService.getNStorageEndPointMap (now used by insert and
insertBlocking after 383)
3. Add unit test fot RackUnawareStrategy to test if bootstrapping nodes are being returned correctly.
patch by Sandeep Tata; reviewed by jbellis for
> Echo writes to bootstrapping nodes
> ----------------------------------
>
> Key: CASSANDRA-375
> URL: https://issues.apache.org/jira/browse/CASSANDRA-375
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Environment: All
> Reporter: Sandeep Tata
> Assignee: Sandeep Tata
> Fix For: 0.5
>
> Attachments: 375-v2.patch, 375.patch
>
>
> Writes that arrive during bootstrap need to be sent to the r replicas as well as the new node being bootstrapped. In the current code, only the existing replicas get the writes that arrive during bootstrap.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.