[jira] [Commented] (BEAM-2674) Runner API translators should own their rehydration

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-2674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16190792#comment-16190792 ] 

ASF GitHub Bot commented on BEAM-2674:
--------------------------------------

GitHub user kennknowles opened a pull request:

    https://github.com/apache/beam/pull/3938

    [BEAM-2674] Add custom rehydration; reinstate proto roundtrip for Java DirectRunner

    Follow this checklist to help us incorporate your contribution quickly and easily:
    
     - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
     - [x] Each commit in the pull request should have a meaningful subject line and body.
     - [x] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue.
     - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
     - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
     - [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/beam DirectRunner-round-trip

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3938.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3938
    
----
commit ad7df083911872886f6361036dffd07744028de8
Author: Kenneth Knowles <kl...@google.com>
Date:   2017-10-03T03:28:16Z

    Add RawPTransform.migrate(SdkComponents) for re-serialization

commit d517167f36d897b3a7a45d29c10db2302a693cc7
Author: Kenneth Knowles <kl...@google.com>
Date:   2017-10-03T02:25:28Z

    Add TransformPayloadTranslator.rehydrate to optionally specialize RawPTransform

commit 9cba4fdb672dd5613fb52e4208e276c33e696f7f
Author: Kenneth Knowles <kl...@google.com>
Date:   2017-10-03T03:20:53Z

    Add custom rehydration for TestStream

commit 4005a02f173fd43b915dd5e9cc14f5638977ebec
Author: Kenneth Knowles <kl...@google.com>
Date:   2017-10-03T18:40:54Z

    Add custom rehydration for Combine

commit 2b9122b5f46a5f64933f7a343a23b40369a15db5
Author: Kenneth Knowles <kl...@google.com>
Date:   2017-10-04T02:17:48Z

    Add custom rehydration for ParDo

commit a992b3de1cc2a9c512c29eddf536d11b31142d8b
Author: Kenneth Knowles <kl...@google.com>
Date:   2017-10-04T04:17:38Z

    Add custom rehydration for WriteFiles

commit 12b2653401aec60fb18344e1d75003ce2e29cce6
Author: Kenn Knowles <ke...@kennknowles.com>
Date:   2017-09-30T17:30:20Z

    Reinstate proto round trip in Java DirectRunner

commit 4e37aaf6b47305ce2fe24e1eac6ef7d6f99cbd8c
Author: Kenneth Knowles <kl...@google.com>
Date:   2017-10-03T22:51:03Z

    Better error message for RehydratedComponents.getCoder

----


> Runner API translators should own their rehydration
> ---------------------------------------------------
>
>                 Key: BEAM-2674
>                 URL: https://issues.apache.org/jira/browse/BEAM-2674
>             Project: Beam
>          Issue Type: New Feature
>          Components: runner-core
>            Reporter: Kenneth Knowles
>            Assignee: Kenneth Knowles
>
> This allows, for example, that a `ParDo` and `Combine` when rehydrated can have its additional inputs set up correctly. Also that `Combine` and others with auxiliary coders can register them appropriately. Currently these happen via sort of hackish one-off methods for each purpose.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)