You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by "mans2singh (via GitHub)" <gi...@apache.org> on 2023/06/17 15:00:41 UTC
[GitHub] [kyuubi] mans2singh opened a new pull request, #4976: ISSUE-4975 - Fixed run tests link
mans2singh opened a new pull request, #4976:
URL: https://github.com/apache/kyuubi/pull/4976
### _Why are the changes needed?_
The run test link in the template is broken.
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on a diff in pull request #4976: [KYUUBI#4975] - Fixed run tests link
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #4976:
URL: https://github.com/apache/kyuubi/pull/4976#discussion_r1233192990
##########
.github/PULL_REQUEST_TEMPLATE:
##########
@@ -20,4 +20,5 @@ Please clarify why the changes are needed. For instance,
- [ ] Add screenshots for manual tests if appropriate
-- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request
+- [ ] [Run test](- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request
Review Comment:
```suggestion
- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 closed pull request #4976: [KYUUBI #4975] Fixed run test link in PR template
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 closed pull request #4976: [KYUUBI #4975] Fixed run test link in PR template
URL: https://github.com/apache/kyuubi/pull/4976
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] mans2singh commented on pull request #4976: [KYUUBI#4975] - Fixed run tests link
Posted by "mans2singh (via GitHub)" <gi...@apache.org>.
mans2singh commented on PR #4976:
URL: https://github.com/apache/kyuubi/pull/4976#issuecomment-1595957295
@pan3793 -
I have updated the PR based on your review. Please let me know if there is anything else required.
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] codecov-commenter commented on pull request #4976: ISSUE-4975 - Fixed run tests link
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #4976:
URL: https://github.com/apache/kyuubi/pull/4976#issuecomment-1595795952
## [Codecov](https://app.codecov.io/gh/apache/kyuubi/pull/4976?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#4976](https://app.codecov.io/gh/apache/kyuubi/pull/4976?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (3734279) into [master](https://app.codecov.io/gh/apache/kyuubi/commit/eeee5c1ae359c28eddccef1158a2eaaae6e7da74?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (eeee5c1) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #4976 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 561 561
Lines 30957 30957
Branches 4061 4061
======================================
Misses 30957 30957
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on pull request #4976: ISSUE-4975 - Fixed run tests link
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #4976:
URL: https://github.com/apache/kyuubi/pull/4976#issuecomment-1595918413
@mans2singh thanks, would you mind reverting unrelated changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on pull request #4976: [KYUUBI #4975] Fixed run test link in PR template
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #4976:
URL: https://github.com/apache/kyuubi/pull/4976#issuecomment-1595960609
Thanks, merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on a diff in pull request #4976: [KYUUBI #4975] Fixed run test link in PR template
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #4976:
URL: https://github.com/apache/kyuubi/pull/4976#discussion_r1233193271
##########
.github/PULL_REQUEST_TEMPLATE:
##########
@@ -20,4 +20,5 @@ Please clarify why the changes are needed. For instance,
- [ ] Add screenshots for manual tests if appropriate
-- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request
+- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request
+) locally before make a pull request
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org