You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2021/04/08 16:35:49 UTC

[GitHub] [drill] oleg-zinovev edited a comment on pull request #2183: DRILL-6547: IllegalStateException: Tried to remove unmanaged buffer in concat function

oleg-zinovev edited a comment on pull request #2183:
URL: https://github.com/apache/drill/pull/2183#issuecomment-815969446


   @paul-rogers , @luocooong , @cgivre 
   Thank you for the additional explanations. I have changed the **ConcatLeftNullInput**, **ConcatBothNullInput** and **ConcatRightNullInput** functions based on your comments.
   
   I have also fixed the same error when using a buffer in the **binary_string** and **string_binary** functions.
   
   I have removed the buffer in the **right**, **regexp_matches**, **substring**, **left** functions, since it was not used in this functions bodies.
   
   And last but not least, I have found buffer overflow error in **replace** function. Should I open another PR, or I can commit fix in current one?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org