You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ws.apache.org by ve...@apache.org on 2016/05/25 07:01:41 UTC

svn commit: r1745447 - in /webservices/axiom/trunk: aspects/om-aspects/src/main/java/org/apache/axiom/om/impl/stream/stax/MTOMXMLStreamWriterImpl.java axiom-api/src/main/java/org/apache/axiom/om/impl/MTOMXMLStreamWriter.java

Author: veithen
Date: Wed May 25 07:01:41 2016
New Revision: 1745447

URL: http://svn.apache.org/viewvc?rev=1745447&view=rev
Log:
Don't allow application code to mutate the internal state of an MTOMXMLStreamWriter.

Modified:
    webservices/axiom/trunk/aspects/om-aspects/src/main/java/org/apache/axiom/om/impl/stream/stax/MTOMXMLStreamWriterImpl.java
    webservices/axiom/trunk/axiom-api/src/main/java/org/apache/axiom/om/impl/MTOMXMLStreamWriter.java

Modified: webservices/axiom/trunk/aspects/om-aspects/src/main/java/org/apache/axiom/om/impl/stream/stax/MTOMXMLStreamWriterImpl.java
URL: http://svn.apache.org/viewvc/webservices/axiom/trunk/aspects/om-aspects/src/main/java/org/apache/axiom/om/impl/stream/stax/MTOMXMLStreamWriterImpl.java?rev=1745447&r1=1745446&r2=1745447&view=diff
==============================================================================
--- webservices/axiom/trunk/aspects/om-aspects/src/main/java/org/apache/axiom/om/impl/stream/stax/MTOMXMLStreamWriterImpl.java (original)
+++ webservices/axiom/trunk/aspects/om-aspects/src/main/java/org/apache/axiom/om/impl/stream/stax/MTOMXMLStreamWriterImpl.java Wed May 25 07:01:41 2016
@@ -45,8 +45,8 @@ import org.apache.commons.logging.LogFac
 
 public class MTOMXMLStreamWriterImpl extends MTOMXMLStreamWriter {
     private static final Log log = LogFactory.getLog(MTOMXMLStreamWriterImpl.class);
-    private XMLStreamWriter xmlWriter;
-    private OMOutputFormat format;
+    private final XMLStreamWriter xmlWriter;
+    private final OMOutputFormat format;
     
     // State variables
     private boolean isEndDocument = false; // has endElement been called
@@ -396,11 +396,6 @@ public class MTOMXMLStreamWriterImpl ext
     }
 
     @Override
-    public void setOutputFormat(OMOutputFormat format) {
-        this.format = format;
-    }
-    
-    @Override
     public OutputStream getOutputStream() throws XMLStreamException {  
         OutputStream outputStream;
         XmlHandler handler = getHandler();

Modified: webservices/axiom/trunk/axiom-api/src/main/java/org/apache/axiom/om/impl/MTOMXMLStreamWriter.java
URL: http://svn.apache.org/viewvc/webservices/axiom/trunk/axiom-api/src/main/java/org/apache/axiom/om/impl/MTOMXMLStreamWriter.java?rev=1745447&r1=1745446&r2=1745447&view=diff
==============================================================================
--- webservices/axiom/trunk/axiom-api/src/main/java/org/apache/axiom/om/impl/MTOMXMLStreamWriter.java (original)
+++ webservices/axiom/trunk/axiom-api/src/main/java/org/apache/axiom/om/impl/MTOMXMLStreamWriter.java Wed May 25 07:01:41 2016
@@ -102,8 +102,6 @@ public abstract class MTOMXMLStreamWrite
      */
     public abstract OMOutputFormat getOutputFormat();
 
-    public abstract void setOutputFormat(OMOutputFormat format);
-    
     /**
      * Get the underlying {@link OutputStream} for this writer, if available. This method allows a
      * node (perhaps an {@link org.apache.axiom.om.OMSourcedElement}) to write its content directly