You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/04/30 09:37:56 UTC

[GitHub] [shardingsphere] cilfm commented on a change in pull request #10217: Update SQLServerDatabaseType.java fix#10126

cilfm commented on a change in pull request #10217:
URL: https://github.com/apache/shardingsphere/pull/10217#discussion_r623748167



##########
File path: shardingsphere-infra/shardingsphere-infra-common/src/main/java/org/apache/shardingsphere/infra/database/type/dialect/SQLServerDatabaseType.java
##########
@@ -41,7 +41,7 @@ public QuoteCharacter getQuoteCharacter() {
     
     @Override
     public Collection<String> getJdbcUrlPrefixes() {
-        return Collections.singletonList("jdbc:microsoft:sqlserver:");
+        return Collections.singletonList("jdbc:sqlserver:");

Review comment:
       You're right. I'm not thoughtful. I've submitted code that matches both cases at the same time.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org